CSS Typed OM: Add TranslationTransformComponent

CSS Typed OM: Add TranslationTransformComponent

Implements TranslationTransformComponent.

Uses Oilpan Member variables for x, y, and z.

Note: 3D Translations cannot have a z component
that contains a percentage.

BUG=545318
Spec: https://drafts.css-houdini.org/css-typed-om/#translation

Committed: https://crrev.com/7105b24d061dffa35f94c595043792cd81f879db
Cr-Commit-Position: refs/heads/master@{#375119}

[tridgell, 2016-02-03 03:31:40]

Description was changed from

==========
CSS Typed OM: Add TranslationTransformComponent

DO NOT SUBMIT.

BUG=
==========

to

==========
CSS Typed OM: Add TranslationTransformComponent

Implements TranslationTransformComponent.

Uses Oilpan Member variables for x, y, and z.

Note: 3D Translations cannot have a z component
that contains a percentage.


BUG=545318
Spec: https://drafts.css-houdini.org/css-typed-om/#translation
==========

[tridgell, 2016-02-03 03:31:40]

tridgell@google.com changed reviewers:
+ meade@chromium.org

[meade_UTC10, 2016-02-03 04:03:29]

meade@chromium.org changed reviewers:
+ alancutter@chromium.org

[meade_UTC10, 2016-02-03 04:03:29]

lgtm

[alancutter (OOO until 2018), 2016-02-09 09:05:55]

lgtm with nits.

https://codereview.chromium.org/1603813002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/cssom/TranslationTransformComponent.h
(right):

https://codereview.chromium.org/1603813002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/cssom/TranslationTransformComponent.h:57: { }
We probably only need one constructor, create() can pass nullptr for z.

https://codereview.chromium.org/1603813002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/cssom/TranslationTransformComponent.h:61:
Member<const LengthValue> m_z;
Not sure if it's reasonable to say these are const if the only thing you do with
them is provide non-const access to these objects.

https://codereview.chromium.org/1603813002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/cssom/TranslationTransformComponent.h:62:
bool m_is2D;
There's no need for m_is2D since you can just nullcheck m_z.

[alancutter (OOO until 2018), 2016-02-10 02:06:24]

https://codereview.chromium.org/1603813002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/cssom/TranslationTransformComponent.h
(right):

https://codereview.chromium.org/1603813002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/cssom/TranslationTransformComponent.h:16:
WTF_MAKE_NONCOPYABLE(TranslationTransformComponent);
This is unnecessary with private constructors.

[tridgell, 2016-02-10 02:30:07]

On 2016/02/10 at 02:06:24, alancutter wrote:
>
https://codereview.chromium.org/1603813002/diff/60001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/css/cssom/TranslationTransformComponent.h
(right):
> 
>
https://codereview.chromium.org/1603813002/diff/60001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/css/cssom/TranslationTransformComponent.h:16:
WTF_MAKE_NONCOPYABLE(TranslationTransformComponent);
> This is unnecessary with private constructors.

Done.  Will submit a separate CL fixing this in other classes.

[tridgell, 2016-02-10 02:32:06]

https://codereview.chromium.org/1603813002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/cssom/TranslationTransformComponent.h
(right):

https://codereview.chromium.org/1603813002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/cssom/TranslationTransformComponent.h:57: { }
On 2016/02/09 at 09:05:55, alancutter wrote:
> We probably only need one constructor, create() can pass nullptr for z.

Done.

https://codereview.chromium.org/1603813002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/cssom/TranslationTransformComponent.h:61:
Member<const LengthValue> m_z;
On 2016/02/09 at 09:05:55, alancutter wrote:
> Not sure if it's reasonable to say these are const if the only thing you do
with them is provide non-const access to these objects.

Done.  As LengthValue is immutable getting rid of const_cast is probably better
practice. Const is now removed from here, and thereby also removed from the
constructor / create method arguments.

https://codereview.chromium.org/1603813002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/cssom/TranslationTransformComponent.h:62:
bool m_is2D;
On 2016/02/09 at 09:05:55, alancutter wrote:
> There's no need for m_is2D since you can just nullcheck m_z.

Done.  Changed to is2D() method, for the sake of tidiness.

[Timothy Loh, 2016-02-10 02:34:58]

timloh@chromium.org changed reviewers:
+ timloh@chromium.org

[Timothy Loh, 2016-02-10 02:34:59]

https://codereview.chromium.org/1603813002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/cssom/TranslationTransformComponent.h
(right):

https://codereview.chromium.org/1603813002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/cssom/TranslationTransformComponent.h:16:
WTF_MAKE_NONCOPYABLE(TranslationTransformComponent);
On 2016/02/10 02:06:24, alancutter wrote:
> This is unnecessary with private constructors.

How so?

[tridgell, 2016-02-10 05:08:30]

Patchset #6 (id:100001) has been deleted

[tridgell, 2016-02-10 05:10:55]

Deleted the patch that removed the macro, so now it is still there.

https://codereview.chromium.org/1603813002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/cssom/TranslationTransformComponent.h
(right):

https://codereview.chromium.org/1603813002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/cssom/TranslationTransformComponent.h:16:
WTF_MAKE_NONCOPYABLE(TranslationTransformComponent);
On 2016/02/10 at 02:34:58, Timothy Loh wrote:
> On 2016/02/10 02:06:24, alancutter wrote:
> > This is unnecessary with private constructors.
> 
> How so?

Resolved.  This macro should be there.

[Timothy Loh, 2016-02-11 05:45:06]

renamed to Translation in spec?

https://codereview.chromium.org/1603813002/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/css/cssom/TranslationTransformComponent.h
(right):

https://codereview.chromium.org/1603813002/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/cssom/TranslationTransformComponent.h:14:
class MatrixTransformComponent;
don't think you need this?

[tridgell, 2016-02-12 03:13:08]

TranslationTransformComponent -> Translation.
See CL https://codereview.chromium.org/1664093002 for similar changes in other
classes.

https://codereview.chromium.org/1603813002/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/css/cssom/TranslationTransformComponent.h
(right):

https://codereview.chromium.org/1603813002/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/cssom/TranslationTransformComponent.h:14:
class MatrixTransformComponent;
On 2016/02/11 at 05:45:06, Timothy Loh wrote:
> don't think you need this?

Done.  Removed.

[Timothy Loh, 2016-02-12 04:12:18]

ok lgtm

[tridgell, 2016-02-12 04:18:03]

The CQ bit was checked by tridgell@google.com

[tridgell, 2016-02-12 04:18:04]

The patchset sent to the CQ was uploaded after l-g-t-m from meade@chromium.org,
alancutter@chromium.org
Link to the patchset: https://codereview.chromium.org/1603813002/#ps140001
(title: "Remove unnecessary class declaraion")

[commit-bot: I haz the power, 2016-02-12 04:19:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1603813002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1603813002/140001

[commit-bot: I haz the power, 2016-02-12 04:25:32]

Description was changed from

==========
CSS Typed OM: Add TranslationTransformComponent

Implements TranslationTransformComponent.

Uses Oilpan Member variables for x, y, and z.

Note: 3D Translations cannot have a z component
that contains a percentage.


BUG=545318
Spec: https://drafts.css-houdini.org/css-typed-om/#translation
==========

to

==========
CSS Typed OM: Add TranslationTransformComponent

Implements TranslationTransformComponent.

Uses Oilpan Member variables for x, y, and z.

Note: 3D Translations cannot have a z component
that contains a percentage.


BUG=545318
Spec: https://drafts.css-houdini.org/css-typed-om/#translation
==========

[commit-bot: I haz the power, 2016-02-12 04:25:33]

Committed patchset #7 (id:140001)

[commit-bot: I haz the power, 2016-02-16 22:41:34]

Description was changed from

==========
CSS Typed OM: Add TranslationTransformComponent

Implements TranslationTransformComponent.

Uses Oilpan Member variables for x, y, and z.

Note: 3D Translations cannot have a z component
that contains a percentage.


BUG=545318
Spec: https://drafts.css-houdini.org/css-typed-om/#translation
==========

to

==========
CSS Typed OM: Add TranslationTransformComponent

Implements TranslationTransformComponent.

Uses Oilpan Member variables for x, y, and z.

Note: 3D Translations cannot have a z component
that contains a percentage.

BUG=545318
Spec: https://drafts.css-houdini.org/css-typed-om/#translation

Committed: https://crrev.com/7105b24d061dffa35f94c595043792cd81f879db
Cr-Commit-Position: refs/heads/master@{#375119}
==========

[commit-bot: I haz the power, 2016-02-16 22:41:35]

Patchset 7 (id:??) landed as
https://crrev.com/7105b24d061dffa35f94c595043792cd81f879db
Cr-Commit-Position: refs/heads/master@{#375119}