Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1689513002: [Abandoned] rename PermissionBubbleRequest to PermissionRequest. (Closed)

Created:
4 years, 10 months ago by mlamouri (slow - plz ping)
Modified:
4 years, 4 months ago
Reviewers:
CC:
asanka, benwells, chromium-reviews, feature-media-reviews_chromium.org, markusheintz_, mcasas+watch_chromium.org, mlamouri+watch-geolocation_chromium.org, mlamouri+watch-permissions_chromium.org, msramek+watch_chromium.org, Michael van Ouwerkerk, posciak+watch_chromium.org, raymes+watch_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@permission-request-manager-rename
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WIP: rename PermissionBubbleRequest to PermissionRequest. This is a step toward having a generic permission request handling for all platforms instead of having desktop-specific bubbles. BUG=<TODO>

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : browser_tests compiles #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -476 lines) Patch
M chrome/browser/chrome_quota_permission_context.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/custom_handlers/register_protocol_handler_permission_request.h View 1 2 chunks +5 lines, -7 lines 0 comments Download
M chrome/browser/download/download_permission_request.h View 1 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/geolocation/geolocation_permission_context_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/media_stream_devices_controller.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
D chrome/browser/permissions/permission_bubble_request_impl.h View 1 1 chunk +0 lines, -66 lines 0 comments Download
D chrome/browser/permissions/permission_bubble_request_impl.cc View 1 1 chunk +0 lines, -170 lines 0 comments Download
M chrome/browser/permissions/permission_context_base.h View 1 5 chunks +7 lines, -8 lines 0 comments Download
M chrome/browser/permissions/permission_context_base.cc View 1 2 4 chunks +8 lines, -9 lines 0 comments Download
A + chrome/browser/permissions/permission_request.h View 1 3 chunks +5 lines, -5 lines 0 comments Download
A + chrome/browser/permissions/permission_request.cc View 1 1 chunk +4 lines, -3 lines 0 comments Download
A + chrome/browser/permissions/permission_request_impl.h View 1 2 chunks +12 lines, -12 lines 0 comments Download
A + chrome/browser/permissions/permission_request_impl.cc View 1 7 chunks +16 lines, -15 lines 0 comments Download
M chrome/browser/permissions/permission_request_manager.h View 1 5 chunks +13 lines, -14 lines 0 comments Download
M chrome/browser/permissions/permission_request_manager.cc View 1 17 chunks +30 lines, -28 lines 0 comments Download
M chrome/browser/permissions/permission_request_manager_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/permissions/permission_uma_util.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/permissions/permission_uma_util.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/website_settings/permissions_bubble_view.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/website_settings/permissions_bubble_view.cc View 1 5 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/website_settings/mock_permission_bubble_request.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/website_settings/mock_permission_bubble_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/website_settings/mock_permission_bubble_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/website_settings/permission_bubble_browser_test_util.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
D chrome/browser/ui/website_settings/permission_bubble_request.h View 1 1 chunk +0 lines, -88 lines 0 comments Download
D chrome/browser/ui/website_settings/permission_bubble_request.cc View 1 1 chunk +0 lines, -15 lines 0 comments Download
M chrome/browser/ui/website_settings/permission_bubble_view.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 6 (2 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1689513002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1689513002/20001
4 years, 8 months ago (2016-04-23 11:54:30 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/201877) linux_chromium_compile_dbg_ng on ...
4 years, 8 months ago (2016-04-23 12:08:28 UTC) #4
mlamouri (slow - plz ping)
Tim and Ben, FYI, I'm closing this. Not sure if you've landed something similar yet.
4 years, 4 months ago (2016-08-10 13:57:58 UTC) #5
tsergeant
4 years, 4 months ago (2016-08-10 23:03:34 UTC) #6
Message was sent while issue was closed.
On 2016/08/10 13:57:58, Mounir Lamouri wrote:
> Tim and Ben, FYI, I'm closing this. Not sure if you've landed something
similar
> yet.

Yup, a number of similar renames have now landed.

Powered by Google App Engine
This is Rietveld 408576698