Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 1686903002: [Abandoned] Rename PermissionBubbleManager to PermissionRequestManager. (Closed)

Created:
4 years, 10 months ago by mlamouri (slow - plz ping)
Modified:
4 years, 4 months ago
Reviewers:
felt
CC:
asanka, benwells, chromium-reviews, feature-media-reviews_chromium.org, markusheintz_, mcasas+watch_chromium.org, mlamouri+watch-geolocation_chromium.org, mlamouri+watch-permissions_chromium.org, msramek+watch_chromium.org, Michael van Ouwerkerk, posciak+watch_chromium.org, raymes+watch_chromium.org, raymes, tfarina, toyoshim+midi_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename PermissionBubbleManager to PermissionRequestManager. In addition of renaming, the CL moves some files from chrome/browser/ui/ to chrome/browser/permissions/. This is a step toward having a generic permission request handling for all platforms instead of desktop-specific bubble system and infobar controller on Android. BUG=606138

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : compile on desktop #

Patch Set 4 : tests compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+383 lines, -1805 lines) Patch
M chrome/browser/chrome_quota_permission_context.cc View 1 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/download/download_browsertest.cc View 1 2 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/download/download_request_limiter.cc View 1 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/download/download_request_limiter_unittest.cc View 1 3 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/extensions/api/webrtc_from_web_accessible_resource_browsertest.cc View 1 2 5 chunks +18 lines, -16 lines 0 comments Download
M chrome/browser/geolocation/geolocation_browsertest.cc View 1 2 15 chunks +56 lines, -55 lines 0 comments Download
M chrome/browser/geolocation/geolocation_permission_context_unittest.cc View 1 2 3 23 chunks +64 lines, -64 lines 0 comments Download
M chrome/browser/media/media_stream_device_permission_context_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/media/media_stream_infobar_browsertest.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/media/midi_permission_context_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/media/permission_bubble_media_access_handler.cc View 1 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/media/webrtc_apprtc_browsertest.cc View 1 2 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/media/webrtc_browsertest_base.cc View 1 2 10 chunks +23 lines, -22 lines 0 comments Download
M chrome/browser/notifications/platform_notification_service_browsertest.cc View 1 2 3 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/permissions/permission_context_base.cc View 1 4 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/permissions/permission_context_base_unittest.cc View 1 4 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/permissions/permission_manager.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/permissions/permission_request_manager.h View 1 6 chunks +14 lines, -14 lines 0 comments Download
A + chrome/browser/permissions/permission_request_manager.cc View 1 23 chunks +37 lines, -37 lines 0 comments Download
A + chrome/browser/permissions/permission_request_manager_browsertest.cc View 1 2 12 chunks +24 lines, -24 lines 0 comments Download
A + chrome/browser/permissions/permission_request_manager_unittest.cc View 1 26 chunks +31 lines, -32 lines 0 comments Download
M chrome/browser/push_messaging/push_messaging_browsertest.cc View 1 2 5 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 1 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/tab_helpers.cc View 1 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 6 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/ui/website_settings/mock_permission_bubble_factory.h View 1 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/website_settings/mock_permission_bubble_factory.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/website_settings/mock_permission_bubble_request.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/website_settings/mock_permission_bubble_view.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/website_settings/mock_permission_bubble_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D chrome/browser/ui/website_settings/permission_bubble_manager.h View 1 1 chunk +0 lines, -194 lines 0 comments Download
D chrome/browser/ui/website_settings/permission_bubble_manager.cc View 1 1 chunk +0 lines, -517 lines 0 comments Download
D chrome/browser/ui/website_settings/permission_bubble_manager_browsertest.cc View 1 2 1 chunk +0 lines, -257 lines 0 comments Download
D chrome/browser/ui/website_settings/permission_bubble_manager_unittest.cc View 1 1 chunk +0 lines, -449 lines 0 comments Download
M chrome/browser/ui/website_settings/permission_bubble_view.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 6 chunks +6 lines, -11 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1686903002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1686903002/20001
4 years, 8 months ago (2016-04-23 11:19:30 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/201876) linux_chromium_compile_dbg_ng on ...
4 years, 8 months ago (2016-04-23 11:32:51 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1686903002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1686903002/40001
4 years, 8 months ago (2016-04-23 12:28:09 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/201880)
4 years, 8 months ago (2016-04-23 12:42:23 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1686903002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1686903002/60001
4 years, 8 months ago (2016-04-23 12:57:23 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/216508)
4 years, 8 months ago (2016-04-23 13:08:32 UTC) #14
mlamouri (slow - plz ping)
Adrienne, can you PTAL. There are minor compile issues to fix but the gist of ...
4 years, 8 months ago (2016-04-26 13:27:23 UTC) #16
mlamouri (slow - plz ping)
After much incomprehension, I finally found why I couldn't reproduce the build issues. The browser ...
4 years, 8 months ago (2016-04-26 13:58:48 UTC) #17
felt
I like it, especially moving into the permissions folder. lgtm % build issues.
4 years, 7 months ago (2016-04-29 01:30:19 UTC) #19
tsergeant
4 years, 6 months ago (2016-05-30 04:08:26 UTC) #20
Hi Mounir,

Has there been any progress on this patch recently?

Powered by Google App Engine
This is Rietveld 408576698