chrome/browser/permissions/permission_uma_util.cc - Issue 1689513002: [Abandoned] rename PermissionBubbleRequest to PermissionRequest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/permissions/permission_uma_util.cc

Issue 1689513002: [Abandoned] rename PermissionBubbleRequest to PermissionRequest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permission-request-manager-rename

Patch Set: browser_tests compiles Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/permissions/permission_uma_util.h ('k') | chrome/browser/ui/views/website_settings/permissions_bubble_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/permissions/permission_uma_util.cc

diff --git a/chrome/browser/permissions/permission_uma_util.cc b/chrome/browser/permissions/permission_uma_util.cc

index 8d38d0451210d25d95cecac7af49fd236e0d2b1b..9b08ebc13b8b6a8fabd659baf67db502fdc69a0a 100644

--- a/chrome/browser/permissions/permission_uma_util.cc

+++ b/chrome/browser/permissions/permission_uma_util.cc

@@ -10,9 +10,9 @@

#include "base/strings/stringprintf.h"

#include "chrome/browser/browser_process.h"

#include "chrome/browser/permissions/permission_manager.h"

+#include "chrome/browser/permissions/permission_request.h"

#include "chrome/browser/permissions/permission_util.h"

#include "chrome/browser/profiles/profile.h"

-#include "chrome/browser/ui/website_settings/permission_bubble_request.h"

#include "components/rappor/rappor_service.h"

#include "components/rappor/rappor_utils.h"

#include "content/public/browser/permission_type.h"

@@ -277,7 +277,7 @@ void PermissionUmaUtil::PermissionRevoked(PermissionType permission,

}

void PermissionUmaUtil::PermissionPromptShown(

- const std::vector<PermissionBubbleRequest*>& requests) {

+ const std::vector<PermissionRequest*>& requests) {

DCHECK(!requests.empty());

PermissionBubbleType permission_prompt_type = PermissionBubbleType::MULTIPLE;

if (requests.size() == 1)