chrome/browser/permissions/permission_uma_util.h - Issue 1689513002: [Abandoned] rename PermissionBubbleRequest to PermissionRequest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/permissions/permission_uma_util.h

Issue 1689513002: [Abandoned] rename PermissionBubbleRequest to PermissionRequest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permission-request-manager-rename

Patch Set: browser_tests compiles Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/permissions/permission_request_manager_unittest.cc ('k') | chrome/browser/permissions/permission_uma_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/permissions/permission_uma_util.h

diff --git a/chrome/browser/permissions/permission_uma_util.h b/chrome/browser/permissions/permission_uma_util.h

index c4c8001d215749510c9f390aad526442da0db199..9a3e653155ab3fc4fad895fd826e7ffb54b8cda0 100644

--- a/chrome/browser/permissions/permission_uma_util.h

+++ b/chrome/browser/permissions/permission_uma_util.h

@@ -17,7 +17,7 @@ namespace content {

enum class PermissionType;

} // namespace content

-class PermissionBubbleRequest;

+class PermissionRequest;

// Enum for UMA purposes, make sure you update histograms.xml if you add new

// permission actions. Never delete or reorder an entry; only add new entries

@@ -63,7 +63,7 @@ class PermissionUmaUtil {

// granted+denied+dismissed+ignored is not equal to requested), so it is

// unclear from those metrics alone how many prompts are seen by users.

static void PermissionPromptShown(

- const std::vector<PermissionBubbleRequest*>& requests);

+ const std::vector<PermissionRequest*>& requests);

private:

DISALLOW_IMPLICIT_CONSTRUCTORS(PermissionUmaUtil);