chrome/browser/ui/views/website_settings/permissions_bubble_view.cc - Issue 1689513002: [Abandoned] rename PermissionBubbleRequest to PermissionRequest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/website_settings/permissions_bubble_view.cc

Issue 1689513002: [Abandoned] rename PermissionBubbleRequest to PermissionRequest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permission-request-manager-rename

Patch Set: browser_tests compiles Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/website_settings/permissions_bubble_view.h ('k') | chrome/browser/ui/website_settings/mock_permission_bubble_request.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/website_settings/permissions_bubble_view.cc

diff --git a/chrome/browser/ui/views/website_settings/permissions_bubble_view.cc b/chrome/browser/ui/views/website_settings/permissions_bubble_view.cc

index 000a4de2e6e36b9dcf5bd1d7154aed5819ee8948..5aea47910f9e2dddbc086042fb4a8c27c363fc38 100644

--- a/chrome/browser/ui/views/website_settings/permissions_bubble_view.cc

+++ b/chrome/browser/ui/views/website_settings/permissions_bubble_view.cc

@@ -9,6 +9,7 @@

#include "base/macros.h"

#include "base/memory/ptr_util.h"

#include "base/strings/string16.h"

+#include "chrome/browser/permissions/permission_request.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/ui/browser.h"

#include "chrome/browser/ui/views/exclusive_access_bubble_views.h"

@@ -18,7 +19,6 @@

#include "chrome/browser/ui/views/location_bar/location_icon_view.h"

#include "chrome/browser/ui/views/website_settings/permission_selector_view.h"

#include "chrome/browser/ui/views/website_settings/permission_selector_view_observer.h"

-#include "chrome/browser/ui/website_settings/permission_bubble_request.h"

#include "chrome/grit/generated_resources.h"

#include "components/url_formatter/elide_url.h"

#include "grit/components_strings.h"

@@ -151,7 +151,7 @@ class PermissionsBubbleDialogDelegateView

views::View* anchor_view,

views::BubbleBorder::Arrow anchor_arrow,

PermissionBubbleViewViews* owner,

- const std::vector<PermissionBubbleRequest*>& requests,

+ const std::vector<PermissionRequest*>& requests,

const std::vector<bool>& accept_state);

~PermissionsBubbleDialogDelegateView() override;

@@ -193,7 +193,7 @@ PermissionsBubbleDialogDelegateView::PermissionsBubbleDialogDelegateView(

views::View* anchor_view,

views::BubbleBorder::Arrow anchor_arrow,

PermissionBubbleViewViews* owner,

- const std::vector<PermissionBubbleRequest*>& requests,

+ const std::vector<PermissionRequest*>& requests,

const std::vector<bool>& accept_state)

: views::BubbleDialogDelegateView(anchor_view, anchor_arrow),

owner_(owner),

@@ -414,7 +414,7 @@ void PermissionBubbleViewViews::SetDelegate(Delegate* delegate) {

}

void PermissionBubbleViewViews::Show(

- const std::vector<PermissionBubbleRequest*>& requests,

+ const std::vector<PermissionRequest*>& requests,

const std::vector<bool>& values) {

if (bubble_delegate_)

bubble_delegate_->CloseBubble();