Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 1685323002: Implement CUP signing in UpdateClient. (Closed)

Created:
4 years, 10 months ago by Sorin Jianu
Modified:
4 years, 10 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, sdefresne+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement CUP signing in UpdateClient. BUG=583027 Committed: https://crrev.com/1bc5eff904e6e20191a0abc2ab7a4c75c31dcc1f Cr-Commit-Position: refs/heads/master@{#375930}

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase and remove duplicated code comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+371 lines, -138 lines) Patch
M chrome/browser/component_updater/chrome_component_updater_configurator.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/extensions/updater/chrome_update_client_config.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/updater/chrome_update_client_config.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M components/component_updater/configurator_impl.h View 1 chunk +3 lines, -0 lines 0 comments Download
M components/component_updater/configurator_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M components/update_client/action_update_check.h View 1 chunk +2 lines, -5 lines 0 comments Download
M components/update_client/action_update_check.cc View 2 chunks +2 lines, -7 lines 0 comments Download
M components/update_client/client_update_protocol_ecdsa.h View 2 chunks +4 lines, -0 lines 0 comments Download
M components/update_client/client_update_protocol_ecdsa.cc View 5 chunks +20 lines, -1 line 0 comments Download
M components/update_client/client_update_protocol_ecdsa_unittest.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M components/update_client/configurator.h View 1 chunk +3 lines, -0 lines 0 comments Download
M components/update_client/ping_manager.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M components/update_client/request_sender.h View 1 1 chunk +40 lines, -10 lines 0 comments Download
M components/update_client/request_sender.cc View 3 chunks +124 lines, -16 lines 0 comments Download
M components/update_client/request_sender_unittest.cc View 11 chunks +62 lines, -22 lines 0 comments Download
M components/update_client/test_configurator.h View 2 chunks +3 lines, -0 lines 0 comments Download
M components/update_client/test_configurator.cc View 3 chunks +10 lines, -2 lines 0 comments Download
M components/update_client/update_checker.h View 2 chunks +1 line, -8 lines 0 comments Download
M components/update_client/update_checker.cc View 4 chunks +16 lines, -33 lines 0 comments Download
M components/update_client/update_checker_unittest.cc View 8 chunks +38 lines, -18 lines 0 comments Download
M components/update_client/update_client_unittest.cc View 10 chunks +13 lines, -13 lines 0 comments Download
M components/update_client/utils.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ios/chrome/browser/component_updater/ios_component_updater_configurator.cc View 3 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
Sorin Jianu
4 years, 10 months ago (2016-02-10 23:51:46 UTC) #2
waffles
lgtm
4 years, 10 months ago (2016-02-11 00:06:14 UTC) #3
Sorin Jianu
Colin, Antony, please, I need owners approval for the configurator paths under the ios and ...
4 years, 10 months ago (2016-02-11 19:01:24 UTC) #6
asargent_no_longer_on_chrome
extensions changes lgtm https://codereview.chromium.org/1685323002/diff/1/chrome/browser/extensions/updater/chrome_update_client_config.cc File chrome/browser/extensions/updater/chrome_update_client_config.cc (right): https://codereview.chromium.org/1685323002/diff/1/chrome/browser/extensions/updater/chrome_update_client_config.cc#newcode91 chrome/browser/extensions/updater/chrome_update_client_config.cc:91: return false; Do we eventually want ...
4 years, 10 months ago (2016-02-11 19:36:52 UTC) #7
Sorin Jianu
Thank you Antony! https://codereview.chromium.org/1685323002/diff/1/chrome/browser/extensions/updater/chrome_update_client_config.cc File chrome/browser/extensions/updater/chrome_update_client_config.cc (right): https://codereview.chromium.org/1685323002/diff/1/chrome/browser/extensions/updater/chrome_update_client_config.cc#newcode91 chrome/browser/extensions/updater/chrome_update_client_config.cc:91: return false; On 2016/02/11 19:36:52, Antony ...
4 years, 10 months ago (2016-02-12 00:43:09 UTC) #8
blundell
blundell -> droger I'm not an //ios OWNER
4 years, 10 months ago (2016-02-12 08:43:47 UTC) #10
droger
ios LGTM
4 years, 10 months ago (2016-02-12 08:55:48 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1685323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1685323002/1
4 years, 10 months ago (2016-02-17 17:12:24 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1685323002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1685323002/20001
4 years, 10 months ago (2016-02-17 17:55:04 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-17 18:45:32 UTC) #19
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 18:47:02 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1bc5eff904e6e20191a0abc2ab7a4c75c31dcc1f
Cr-Commit-Position: refs/heads/master@{#375930}

Powered by Google App Engine
This is Rietveld 408576698