Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Unified Diff: components/update_client/action_update_check.cc

Issue 1685323002: Implement CUP signing in UpdateClient. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase and remove duplicated code comment. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/update_client/action_update_check.cc
diff --git a/components/update_client/action_update_check.cc b/components/update_client/action_update_check.cc
index 5c411c4932b57ff6f4a1be41b8986552d9e1489b..9e31eb6d33d30f8aa8d43e836ee709e8a53518f9 100644
--- a/components/update_client/action_update_check.cc
+++ b/components/update_client/action_update_check.cc
@@ -96,18 +96,14 @@ void ActionUpdateCheck::Run(UpdateContext* update_context, Callback callback) {
}
void ActionUpdateCheck::UpdateCheckComplete(
- const GURL& original_url,
int error,
- const std::string& error_message,
const UpdateResponse::Results& results) {
DCHECK(thread_checker_.CalledOnValidThread());
- VLOG(1) << "Update check completed from: " << original_url.spec();
-
if (!error)
OnUpdateCheckSucceeded(results);
else
- OnUpdateCheckFailed(error, error_message);
+ OnUpdateCheckFailed(error);
}
void ActionUpdateCheck::OnUpdateCheckSucceeded(
@@ -198,8 +194,7 @@ void ActionUpdateCheck::OnUpdateCheckSucceeded(
UpdateCrx();
}
-void ActionUpdateCheck::OnUpdateCheckFailed(int error,
- const std::string& error_message) {
+void ActionUpdateCheck::OnUpdateCheckFailed(int error) {
DCHECK(thread_checker_.CalledOnValidThread());
DCHECK(error);
« no previous file with comments | « components/update_client/action_update_check.h ('k') | components/update_client/client_update_protocol_ecdsa.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698