Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(934)

Unified Diff: components/update_client/ping_manager.cc

Issue 1685323002: Implement CUP signing in UpdateClient. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase and remove duplicated code comment. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/update_client/configurator.h ('k') | components/update_client/request_sender.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/update_client/ping_manager.cc
diff --git a/components/update_client/ping_manager.cc b/components/update_client/ping_manager.cc
index 17bcdd610591fd03d51d999b6a3b474306255375..191881457b5596271de9231e6449a8f37b3dd060 100644
--- a/components/update_client/ping_manager.cc
+++ b/components/update_client/ping_manager.cc
@@ -179,7 +179,7 @@ class PingSender {
bool SendPing(const CrxUpdateItem* item);
private:
- void OnRequestSenderComplete(const net::URLFetcher* source);
+ void OnRequestSenderComplete(int error, const std::string& response);
const scoped_refptr<Configurator> config_;
scoped_ptr<RequestSender> request_sender_;
@@ -195,7 +195,8 @@ PingSender::~PingSender() {
DCHECK(thread_checker_.CalledOnValidThread());
}
-void PingSender::OnRequestSenderComplete(const net::URLFetcher* source) {
+void PingSender::OnRequestSenderComplete(int error,
+ const std::string& response) {
DCHECK(thread_checker_.CalledOnValidThread());
delete this;
}
@@ -211,7 +212,7 @@ bool PingSender::SendPing(const CrxUpdateItem* item) {
request_sender_.reset(new RequestSender(config_));
request_sender_->Send(
- BuildPing(*config_, item), urls,
+ false, BuildPing(*config_, item), urls,
base::Bind(&PingSender::OnRequestSenderComplete, base::Unretained(this)));
return true;
}
« no previous file with comments | « components/update_client/configurator.h ('k') | components/update_client/request_sender.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698