components/update_client/action_update_check.h - Issue 1685323002: Implement CUP signing in UpdateClient.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/update_client/action_update_check.h

Issue 1685323002: Implement CUP signing in UpdateClient. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase and remove duplicated code comment. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/update_client/action_update_check.h

diff --git a/components/update_client/action_update_check.h b/components/update_client/action_update_check.h

index b5f1d2437923d8f83ea6b67f4f4e8ae11a373e52..7576d64373669b6d2d16b83dfbc9a6b1b4421837 100644

--- a/components/update_client/action_update_check.h

+++ b/components/update_client/action_update_check.h

@@ -36,13 +36,10 @@ class ActionUpdateCheck : public Action, private ActionImpl {

void Run(UpdateContext* update_context, Callback callback) override;

private:

- void UpdateCheckComplete(const GURL& original_url,

- int error,

- const std::string& error_message,

- const UpdateResponse::Results& results);

+ void UpdateCheckComplete(int error, const UpdateResponse::Results& results);

void OnUpdateCheckSucceeded(const UpdateResponse::Results& results);

- void OnUpdateCheckFailed(int error, const std::string& error_message);

+ void OnUpdateCheckFailed(int error);

scoped_ptr<UpdateChecker> update_checker_;

const base::Version browser_version_;