Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Unified Diff: components/update_client/update_client_unittest.cc

Issue 1685323002: Implement CUP signing in UpdateClient. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase and remove duplicated code comment. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/update_client/update_checker_unittest.cc ('k') | components/update_client/utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/update_client/update_client_unittest.cc
diff --git a/components/update_client/update_client_unittest.cc b/components/update_client/update_client_unittest.cc
index 8a245ad0af38019b9d2000ba496fba463fcd522c..a0bee0fec94515278aa5c4d2c8a134953ea2d221 100644
--- a/components/update_client/update_client_unittest.cc
+++ b/components/update_client/update_client_unittest.cc
@@ -226,8 +226,8 @@ TEST_F(UpdateClientTest, OneCrxNoUpdate) {
const std::string& additional_attributes,
const UpdateCheckCallback& update_check_callback) override {
base::ThreadTaskRunnerHandle::Get()->PostTask(
- FROM_HERE, base::Bind(update_check_callback, GURL(), 0, "",
- UpdateResponse::Results()));
+ FROM_HERE,
+ base::Bind(update_check_callback, 0, UpdateResponse::Results()));
return true;
}
};
@@ -368,7 +368,7 @@ TEST_F(UpdateClientTest, TwoCrxUpdateNoUpdate) {
results.list.push_back(result);
base::ThreadTaskRunnerHandle::Get()->PostTask(
- FROM_HERE, base::Bind(update_check_callback, GURL(), 0, "", results));
+ FROM_HERE, base::Bind(update_check_callback, 0, results));
return true;
}
};
@@ -580,7 +580,7 @@ TEST_F(UpdateClientTest, TwoCrxUpdate) {
results.list.push_back(result2);
base::ThreadTaskRunnerHandle::Get()->PostTask(
- FROM_HERE, base::Bind(update_check_callback, GURL(), 0, "", results));
+ FROM_HERE, base::Bind(update_check_callback, 0, results));
return true;
}
};
@@ -827,7 +827,7 @@ TEST_F(UpdateClientTest, TwoCrxUpdateDownloadTimeout) {
results.list.push_back(result2);
base::ThreadTaskRunnerHandle::Get()->PostTask(
- FROM_HERE, base::Bind(update_check_callback, GURL(), 0, "", results));
+ FROM_HERE, base::Bind(update_check_callback, 0, results));
return true;
}
};
@@ -1099,7 +1099,7 @@ TEST_F(UpdateClientTest, OneCrxDiffUpdate) {
}
base::ThreadTaskRunnerHandle::Get()->PostTask(
- FROM_HERE, base::Bind(update_check_callback, GURL(), 0, "", results));
+ FROM_HERE, base::Bind(update_check_callback, 0, results));
return true;
}
};
@@ -1340,7 +1340,7 @@ TEST_F(UpdateClientTest, OneCrxInstallError) {
results.list.push_back(result);
base::ThreadTaskRunnerHandle::Get()->PostTask(
- FROM_HERE, base::Bind(update_check_callback, GURL(), 0, "", results));
+ FROM_HERE, base::Bind(update_check_callback, 0, results));
return true;
}
};
@@ -1573,7 +1573,7 @@ TEST_F(UpdateClientTest, OneCrxDiffUpdateFailsFullUpdateSucceeds) {
}
base::ThreadTaskRunnerHandle::Get()->PostTask(
- FROM_HERE, base::Bind(update_check_callback, GURL(), 0, "", results));
+ FROM_HERE, base::Bind(update_check_callback, 0, results));
return true;
}
};
@@ -1777,8 +1777,8 @@ TEST_F(UpdateClientTest, OneCrxNoUpdateQueuedCall) {
const std::string& additional_attributes,
const UpdateCheckCallback& update_check_callback) override {
base::ThreadTaskRunnerHandle::Get()->PostTask(
- FROM_HERE, base::Bind(update_check_callback, GURL(), 0, "",
- UpdateResponse::Results()));
+ FROM_HERE,
+ base::Bind(update_check_callback, 0, UpdateResponse::Results()));
return true;
}
};
@@ -1911,7 +1911,7 @@ TEST_F(UpdateClientTest, OneCrxInstall) {
results.list.push_back(result);
base::ThreadTaskRunnerHandle::Get()->PostTask(
- FROM_HERE, base::Bind(update_check_callback, GURL(), 0, "", results));
+ FROM_HERE, base::Bind(update_check_callback, 0, results));
return true;
}
};
@@ -2062,8 +2062,8 @@ TEST_F(UpdateClientTest, ConcurrentInstallSameCRX) {
const std::string& additional_attributes,
const UpdateCheckCallback& update_check_callback) override {
base::ThreadTaskRunnerHandle::Get()->PostTask(
- FROM_HERE, base::Bind(update_check_callback, GURL(), 0, "",
- UpdateResponse::Results()));
+ FROM_HERE,
+ base::Bind(update_check_callback, 0, UpdateResponse::Results()));
return true;
}
};
« no previous file with comments | « components/update_client/update_checker_unittest.cc ('k') | components/update_client/utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698