Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1684793003: Add comments for struct members that were changed from size_t to uin32_t or uint64_t for IPC safety. (Closed)

Created:
4 years, 10 months ago by jam
Modified:
4 years, 10 months ago
Reviewers:
Tom Sepez
CC:
chromium-reviews, browser-components-watch_chromium.org, bondd+autofillwatch_chromium.org, miu+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, jam, rlp+watch_chromium.org, groby+spellwatch_chromium.org, chromium-apps-reviews_chromium.org, xjz+watch_chromium.org, imcheng+watch_chromium.org, rouslan+autofill_chromium.org, jasonroberts+watch_google.com, feature-media-reviews_chromium.org, rouslan+spell_chromium.org, piman+watch_chromium.org, avayvod+watch_chromium.org, jdonnelly+autofillwatch_chromium.org, darin-cc_chromium.org, estade+watch_chromium.org, vabr+watchlistautofill_chromium.org, isheriff+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add comments for struct members that were changed from size_t to uin32_t or uint64_t for IPC safety. Also add a few checked_cast for places where we converted from size_t and we're sure that it's safe. BUG=581409 Committed: https://crrev.com/ffaec53850a27fc0888998c98c7bb092ccbd8552 Cr-Commit-Position: refs/heads/master@{#374788}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -11 lines) Patch
M chrome/browser/task_management/sampling/task_group.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/task_manager/task_manager.cc View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/common/spellcheck_marker.h View 1 chunk +3 lines, -0 lines 0 comments Download
M components/autofill/core/common/form_field_data.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/common/gpu/gpu_memory_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/gpu_memory_uma_stats.h View 2 chunks +4 lines, -2 lines 0 comments Download
M content/public/common/gpu_memory_stats.h View 3 chunks +5 lines, -3 lines 0 comments Download
M extensions/common/stack_frame.h View 1 chunk +3 lines, -0 lines 0 comments Download
M media/cast/logging/logging_defines.h View 1 chunk +2 lines, -0 lines 0 comments Download
M media/cast/net/pacing/paced_sender.cc View 2 chunks +2 lines, -1 line 0 comments Download
M media/cast/receiver/frame_receiver.cc View 2 chunks +2 lines, -1 line 0 comments Download
M media/cast/sender/frame_sender.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/gfx/range/range.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jam
4 years, 10 months ago (2016-02-10 18:27:58 UTC) #2
Tom Sepez
Thanks. LGTM.
4 years, 10 months ago (2016-02-10 20:51:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1684793003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1684793003/1
4 years, 10 months ago (2016-02-10 21:42:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-10 23:45:52 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:32:46 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ffaec53850a27fc0888998c98c7bb092ccbd8552
Cr-Commit-Position: refs/heads/master@{#374788}

Powered by Google App Engine
This is Rietveld 408576698