Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Side by Side Diff: content/common/gpu/gpu_memory_uma_stats.h

Issue 1684793003: Add comments for struct members that were changed from size_t to uin32_t or uint64_t for IPC safety. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/common/gpu/gpu_memory_manager.cc ('k') | content/public/common/gpu_memory_stats.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_COMMON_GPU_GPU_MEMORY_UMA_STATS_H_ 5 #ifndef CONTENT_COMMON_GPU_GPU_MEMORY_UMA_STATS_H_
6 #define CONTENT_COMMON_GPU_GPU_MEMORY_UMA_STATS_H_ 6 #define CONTENT_COMMON_GPU_GPU_MEMORY_UMA_STATS_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 9
10 namespace content { 10 namespace content {
11 11
12 // Memory usage statistics send periodically to the browser process to report 12 // Memory usage statistics send periodically to the browser process to report
13 // in UMA histograms if the GPU process crashes. 13 // in UMA histograms if the GPU process crashes.
14 // Note: we use uint64_t instead of size_t for byte count because this struct
15 // is sent over IPC which could span 32 & 64 bit processes.
14 struct GPUMemoryUmaStats { 16 struct GPUMemoryUmaStats {
15 GPUMemoryUmaStats() 17 GPUMemoryUmaStats()
16 : bytes_allocated_current(0), 18 : bytes_allocated_current(0),
17 bytes_allocated_max(0), 19 bytes_allocated_max(0),
18 context_group_count(0) { 20 context_group_count(0) {
19 } 21 }
20 22
21 // The number of bytes currently allocated. 23 // The number of bytes currently allocated.
22 uint32_t bytes_allocated_current; 24 uint64_t bytes_allocated_current;
23 25
24 // The maximum number of bytes ever allocated at once. 26 // The maximum number of bytes ever allocated at once.
25 uint32_t bytes_allocated_max; 27 uint64_t bytes_allocated_max;
26 28
27 // The number of context groups. 29 // The number of context groups.
28 uint32_t context_group_count; 30 uint32_t context_group_count;
29 }; 31 };
30 32
31 } // namespace content 33 } // namespace content
32 34
33 #endif // CONTENT_COMMON_GPU_GPU_MEMORY_UMA_STATS_H_ 35 #endif // CONTENT_COMMON_GPU_GPU_MEMORY_UMA_STATS_H_
OLDNEW
« no previous file with comments | « content/common/gpu/gpu_memory_manager.cc ('k') | content/public/common/gpu_memory_stats.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698