Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Unified Diff: extensions/common/stack_frame.h

Issue 1684793003: Add comments for struct members that were changed from size_t to uin32_t or uint64_t for IPC safety. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/common/gpu_memory_stats.h ('k') | media/cast/logging/logging_defines.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/stack_frame.h
diff --git a/extensions/common/stack_frame.h b/extensions/common/stack_frame.h
index b174ffc71ea47240321e4900b694adac774f0ec6..033784a285dee23b1a89aad9ebeb97f930a2f802 100644
--- a/extensions/common/stack_frame.h
+++ b/extensions/common/stack_frame.h
@@ -29,6 +29,9 @@ struct StackFrame {
bool operator==(const StackFrame& rhs) const;
+ // Note: we use uint32_t instead of size_t because this struct is sent over
+ // IPC which could span 32 & 64 bit processes. This is fine since line numbers
+ // and column numbers shouldn't exceed UINT32_MAX even on 64 bit builds.
uint32_t line_number;
uint32_t column_number;
base::string16 source;
« no previous file with comments | « content/public/common/gpu_memory_stats.h ('k') | media/cast/logging/logging_defines.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698