Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(808)

Side by Side Diff: chrome/common/spellcheck_marker.h

Issue 1684793003: Add comments for struct members that were changed from size_t to uin32_t or uint64_t for IPC safety. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_COMMON_SPELLCHECK_MARKER_H_ 5 #ifndef CHROME_COMMON_SPELLCHECK_MARKER_H_
6 #define CHROME_COMMON_SPELLCHECK_MARKER_H_ 6 #define CHROME_COMMON_SPELLCHECK_MARKER_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 11 matching lines...) Expand all
22 size_t text_length_; 22 size_t text_length_;
23 }; 23 };
24 24
25 // IPC requires a default constructor. 25 // IPC requires a default constructor.
26 SpellCheckMarker() : hash(0xFFFFFFFF), offset(UINT32_MAX) {} 26 SpellCheckMarker() : hash(0xFFFFFFFF), offset(UINT32_MAX) {}
27 27
28 SpellCheckMarker(uint32_t hash, uint32_t offset) 28 SpellCheckMarker(uint32_t hash, uint32_t offset)
29 : hash(hash), offset(offset) {} 29 : hash(hash), offset(offset) {}
30 30
31 uint32_t hash; 31 uint32_t hash;
32 // Note: we use uint32_t instead of size_t because this struct is sent over
33 // IPC which could span 32 & 64 bit processes. This is fine since the offset
34 // shouldn't exceed UINT32_MAX even on 64 bit builds.
32 uint32_t offset; 35 uint32_t offset;
33 }; 36 };
34 37
35 #endif // CHROME_COMMON_SPELLCHECK_MARKER_H_ 38 #endif // CHROME_COMMON_SPELLCHECK_MARKER_H_
OLDNEW
« no previous file with comments | « chrome/browser/task_manager/task_manager.cc ('k') | components/autofill/core/common/form_field_data.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698