Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Side by Side Diff: extensions/common/stack_frame.h

Issue 1684793003: Add comments for struct members that were changed from size_t to uin32_t or uint64_t for IPC safety. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/public/common/gpu_memory_stats.h ('k') | media/cast/logging/logging_defines.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef EXTENSIONS_COMMON_STACK_FRAME_H_ 5 #ifndef EXTENSIONS_COMMON_STACK_FRAME_H_
6 #define EXTENSIONS_COMMON_STACK_FRAME_H_ 6 #define EXTENSIONS_COMMON_STACK_FRAME_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 9
10 #include <vector> 10 #include <vector>
(...skipping 11 matching lines...) Expand all
22 const base::string16& source, 22 const base::string16& source,
23 const base::string16& function); 23 const base::string16& function);
24 ~StackFrame(); 24 ~StackFrame();
25 25
26 // Construct a stack frame from a reported plain-text frame. 26 // Construct a stack frame from a reported plain-text frame.
27 static scoped_ptr<StackFrame> CreateFromText( 27 static scoped_ptr<StackFrame> CreateFromText(
28 const base::string16& frame_text); 28 const base::string16& frame_text);
29 29
30 bool operator==(const StackFrame& rhs) const; 30 bool operator==(const StackFrame& rhs) const;
31 31
32 // Note: we use uint32_t instead of size_t because this struct is sent over
33 // IPC which could span 32 & 64 bit processes. This is fine since line numbers
34 // and column numbers shouldn't exceed UINT32_MAX even on 64 bit builds.
32 uint32_t line_number; 35 uint32_t line_number;
33 uint32_t column_number; 36 uint32_t column_number;
34 base::string16 source; 37 base::string16 source;
35 base::string16 function; // optional 38 base::string16 function; // optional
36 }; 39 };
37 40
38 typedef std::vector<StackFrame> StackTrace; 41 typedef std::vector<StackFrame> StackTrace;
39 42
40 } // namespace extensions 43 } // namespace extensions
41 44
42 #endif // EXTENSIONS_COMMON_STACK_FRAME_H_ 45 #endif // EXTENSIONS_COMMON_STACK_FRAME_H_
43 46
OLDNEW
« no previous file with comments | « content/public/common/gpu_memory_stats.h ('k') | media/cast/logging/logging_defines.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698