Remove ContextScope from visitDOMWrapper

Remove Context::Scope from visitDOMWrapper

visitDOMWrapper should not create a Context::Scope.
Alternately, it should visit wrappers of all worlds
(currently the binding layer is assuming that wrappers of all worlds
are kept alive if any of the wrappers is alive).

Also it is important to remove the Context::Scope because if DOM has a long reference chain
to be visited, the Context::Scopes created on the stack can overflow and cause crashes.

BUG=455160, 610340
Committed: https://crrev.com/b1b2e5dd2b1f6c4b314a813987724812e13fbc18
Cr-Commit-Position: refs/heads/master@{#393492}

[haraken, 2016-02-09 05:36:45]

haraken@chromium.org changed reviewers:
+ jochen@chromium.org, yukishiino@chromium.org

[haraken, 2016-02-09 05:36:46]

yukishiino@: PTAL.

[Yuki, 2016-02-09 06:55:07]

lgtm

[haraken, 2016-02-09 07:24:12]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2016-02-09 07:24:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1683493003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1683493003/1

[commit-bot: I haz the power, 2016-02-09 10:04:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-09 10:04:44]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[haraken, 2016-02-09 10:27:40]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2016-02-09 10:28:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1683493003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1683493003/1

[commit-bot: I haz the power, 2016-02-09 13:03:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-09 13:03:18]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[haraken, 2016-02-09 14:27:26]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2016-02-09 14:27:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1683493003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1683493003/1

[commit-bot: I haz the power, 2016-02-09 17:19:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-09 17:19:47]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[haraken, 2016-02-09 23:47:33]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2016-02-09 23:49:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1683493003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1683493003/1

[commit-bot: I haz the power, 2016-02-10 02:28:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-10 02:28:57]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[jochen (gone - plz use gerrit), 2016-02-17 11:04:04]

lgtm

[haraken, 2016-05-13 07:29:12]

Description was changed from

==========
Remove ContextScope from visitDOMWrapper

https://codereview.chromium.org/1221193004 removed code to create
a V8 wrapper in visitDOMWrapper. So we no longer need to enter
a ContextScope in visitDOMWrapper.

BUG==455160
==========

to

==========
Remove Context::Scope from visitDOMWrapper

visitDOMWrapper should not create a Context::Scope.
Alternately, it should visit wrappers of all worlds
(currently the binding layer is assuming that wrappers of all worlds
are kept alive if any of the wrappers is alive).

Also it is important to remove the Context::Scope because if DOM has a long
reference chain
to be visited, the Context::Scopes created on the stack can overflow and cause
crashes.

BUG=455160,610340
==========

[haraken, 2016-05-13 07:29:12]

haraken@chromium.org changed reviewers:
+ sigbjornf@opera.com

[haraken, 2016-05-13 07:51:57]

The bots are green. PTAL.

[Yuki, 2016-05-13 08:05:22]

lgtm

https://codereview.chromium.org/1683493003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.cpp (right):

https://codereview.chromium.org/1683493003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.cpp:167: for (auto&
keyValuePair : isolatedWorlds) {
super nit: The name of keyValuePair looks meaningless.
I don't have a good idea, but |idAndWorld| would make more sense.

[haraken, 2016-05-13 08:59:56]

https://codereview.chromium.org/1683493003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.cpp (right):

https://codereview.chromium.org/1683493003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.cpp:167: for (auto&
keyValuePair : isolatedWorlds) {
On 2016/05/13 08:05:22, Yuki wrote:
> super nit: The name of keyValuePair looks meaningless.
> I don't have a good idea, but |idAndWorld| would make more sense.

Done.

[haraken, 2016-05-13 09:00:21]

The CQ bit was checked by haraken@chromium.org

[haraken, 2016-05-13 09:00:21]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
yukishiino@chromium.org
Link to the patchset: https://codereview.chromium.org/1683493003/#ps80001
(title: " ")

[commit-bot: I haz the power, 2016-05-13 09:00:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1683493003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1683493003/80001

[commit-bot: I haz the power, 2016-05-13 10:12:49]

Description was changed from

==========
Remove Context::Scope from visitDOMWrapper

visitDOMWrapper should not create a Context::Scope.
Alternately, it should visit wrappers of all worlds
(currently the binding layer is assuming that wrappers of all worlds
are kept alive if any of the wrappers is alive).

Also it is important to remove the Context::Scope because if DOM has a long
reference chain
to be visited, the Context::Scopes created on the stack can overflow and cause
crashes.

BUG=455160,610340
==========

to

==========
Remove Context::Scope from visitDOMWrapper

visitDOMWrapper should not create a Context::Scope.
Alternately, it should visit wrappers of all worlds
(currently the binding layer is assuming that wrappers of all worlds
are kept alive if any of the wrappers is alive).

Also it is important to remove the Context::Scope because if DOM has a long
reference chain
to be visited, the Context::Scopes created on the stack can overflow and cause
crashes.

BUG=455160,610340
==========

[commit-bot: I haz the power, 2016-05-13 10:12:50]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-05-13 10:14:16]

Description was changed from

==========
Remove Context::Scope from visitDOMWrapper

visitDOMWrapper should not create a Context::Scope.
Alternately, it should visit wrappers of all worlds
(currently the binding layer is assuming that wrappers of all worlds
are kept alive if any of the wrappers is alive).

Also it is important to remove the Context::Scope because if DOM has a long
reference chain
to be visited, the Context::Scopes created on the stack can overflow and cause
crashes.

BUG=455160,610340
==========

to

==========
Remove Context::Scope from visitDOMWrapper

visitDOMWrapper should not create a Context::Scope.
Alternately, it should visit wrappers of all worlds
(currently the binding layer is assuming that wrappers of all worlds
are kept alive if any of the wrappers is alive).

Also it is important to remove the Context::Scope because if DOM has a long
reference chain
to be visited, the Context::Scopes created on the stack can overflow and cause
crashes.

BUG=455160,610340

Committed: https://crrev.com/b1b2e5dd2b1f6c4b314a813987724812e13fbc18
Cr-Commit-Position: refs/heads/master@{#393492}
==========

[commit-bot: I haz the power, 2016-05-13 10:14:18]

Patchset 5 (id:??) landed as
https://crrev.com/b1b2e5dd2b1f6c4b314a813987724812e13fbc18
Cr-Commit-Position: refs/heads/master@{#393492}