Issue 1221193004: Bindings: visitDOMWrapper should not create a new wrapper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1221193004: Bindings: visitDOMWrapper should not create a new wrapper (Closed)

Created:
5 years, 5 months ago by haraken

Modified:
5 years, 5 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
arv+blink, blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, vivekg

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Bindings: visitDOMWrapper should not create a new wrapper We're not allowed to create a wrapper during VisitPersistentHandles. Thus this CL removes code to create a new wrapper in visitDOMWrapper for [SetWrapperReferenceTo]. If the wrapper doesn't exist at that point, visitDOMWrapper returns immediately without creating any hidden reference. The reason why this change is OK is complicated and explained in https://codereview.chromium.org/1200613002/#msg14 in details. BUG=467211 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198465

Patch Set 1 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -9 lines)			Patch
M	Source/bindings/templates/interface.cpp	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	Source/bindings/tests/results/core/V8TestInterface.cpp	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	Source/bindings/tests/results/modules/V8TestInterface5.cpp	View	1 chunk	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1221193004/1

5 years, 5 months ago (2015-07-08 05:18:09 UTC) #5

commit-bot: I haz the power

5 years, 5 months ago (2015-07-08 05:22:11 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198465

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages