Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Unified Diff: third_party/WebKit/Source/bindings/templates/interface.cpp

Issue 1683493003: Remove ContextScope from visitDOMWrapper (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/templates/interface.cpp
diff --git a/third_party/WebKit/Source/bindings/templates/interface.cpp b/third_party/WebKit/Source/bindings/templates/interface.cpp
index 255f87d580dec65c0f676185b74bcd4c7b172da7..932323f1dcaf0db75111af367d0b1a14328bf758 100644
--- a/third_party/WebKit/Source/bindings/templates/interface.cpp
+++ b/third_party/WebKit/Source/bindings/templates/interface.cpp
@@ -551,12 +551,9 @@ void {{v8_class}}::visitDOMWrapper(v8::Isolate* isolate, ScriptWrappable* script
{
{{cpp_class}}* impl = scriptWrappable->toImpl<{{cpp_class}}>();
{% if set_wrapper_reference_to %}
- v8::Local<v8::Object> context = v8::Local<v8::Object>::New(isolate, wrapper);
- v8::Context::Scope scope(context->CreationContext());
{{set_wrapper_reference_to.cpp_type}} {{set_wrapper_reference_to.name}} = impl->{{set_wrapper_reference_to.name}}();
if ({{set_wrapper_reference_to.name}}) {
- if (DOMDataStore::containsWrapper({{set_wrapper_reference_to.name}}, isolate))
- DOMDataStore::setWrapperReference(wrapper, {{set_wrapper_reference_to.name}}, isolate);
+ DOMWrapperWorld::setWrapperReferencesInAllWorlds(wrapper, {{set_wrapper_reference_to.name}}, isolate);
}
{% endif %}
{% if set_wrapper_reference_from %}

Powered by Google App Engine
This is Rietveld 408576698