third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp - Issue 1683493003: Remove ContextScope from visitDOMWrapper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp

Issue 1683493003: Remove ContextScope from visitDOMWrapper (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/templates/interface.cpp ('k') | third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface5.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp

diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp b/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp

index 9308d44a11d76d93e111b74e2e4b285878d2c124..2f8dde001a5d85772ec3633aadf851d730bc42c0 100644

--- a/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp

+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp

@@ -1978,12 +1978,9 @@ static void namedPropertyEnumeratorCallback(const v8::PropertyCallbackInfo<v8::A

void V8TestInterface::visitDOMWrapper(v8::Isolate* isolate, ScriptWrappable* scriptWrappable, const v8::Persistent<v8::Object>& wrapper)

{

TestInterfaceImplementation* impl = scriptWrappable->toImpl<TestInterfaceImplementation>();

- v8::Local<v8::Object> context = v8::Local<v8::Object>::New(isolate, wrapper);

- v8::Context::Scope scope(context->CreationContext());

TestInterfaceImplementation* referencedName = impl->referencedName();

if (referencedName) {

- if (DOMDataStore::containsWrapper(referencedName, isolate))

- DOMDataStore::setWrapperReference(wrapper, referencedName, isolate);

+ DOMWrapperWorld::setWrapperReferencesInAllWorlds(wrapper, referencedName, isolate);

}