Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Issue 1681813002: Rename Connection::AddService/ConnectToService to Connection::AddInterface/GetInterface (Closed)

Created:
4 years, 10 months ago by Ben Goodger (Google)
Modified:
4 years, 10 months ago
CC:
chromium-reviews, rjkroege, mlamouri+watch-content_chromium.org, feature-media-reviews_chromium.org, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, penghuang+watch-mandoline_chromium.org, jam, dcheng, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, yzshen+watch_chromium.org, devtools-reviews_chromium.org, mkwst+moarreviews-renderer_chromium.org, kalyank, darin (slow to review), ben+mojo_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@interface_binder
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename Connection::AddService/ConnectToService to Connection::AddInterface/GetInterface TBR=rockot@chromium.org BUG= Committed: https://crrev.com/123d058c611dbbae160667a0ccbed49785f54f17 Cr-Commit-Position: refs/heads/master@{#374328}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -109 lines) Patch
M components/clipboard/clipboard_application_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/devtools_service/devtools_service_delegate.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/filesystem/file_system_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/font_service/font_service_app.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/html_viewer/ax_provider_apptest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/html_viewer/blink_platform_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/html_viewer/html_document.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M components/html_viewer/html_document_application_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/html_viewer/html_frame_apptest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/html_viewer/html_viewer.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/html_viewer/stats_collection_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/mus/mus_app.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M components/mus/public/cpp/tests/window_server_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/window_tree_apptest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/pdf_viewer/pdf_viewer.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/resource_provider/resource_provider_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/web_view/frame_apptest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/web_view/frame_connection.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/web_view/test_runner/test_runner_application_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/web_view/web_view_application_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/web_view/web_view_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/test_mojo_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/mus/render_widget_window_tree_client_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/devices_app/devices_app.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mandoline/services/core_services/core_services_application_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M mandoline/services/updater/updater_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M mandoline/ui/desktop_ui/browser_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M mandoline/ui/desktop_ui/browser_window.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mandoline/ui/omnibox/omnibox_application.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mandoline/ui/phone_ui/phone_browser_application_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M mash/shell/shell_application_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M mash/wm/window_manager_application.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/mojo/services/media_apptest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/services/mojo_media_application.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/tests/versioning_test_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/http_server_apptest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/services/network/network_service_delegate.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M mojo/services/test_service/test_request_tracker_application.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/services/test_service/test_service_application.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/services/tracing/public/cpp/tracing_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/tracing/tracing_app.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/shell/application_manager_apptest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/shell/application_manager_apptest_driver.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/application_manager_unittest.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M mojo/shell/application_package_apptest.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M mojo/shell/capability_filter_test.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/shell/fetcher/about_fetcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/package_manager/capability_filter_content_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/package_manager/content_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/public/cpp/connection.h View 4 chunks +7 lines, -7 lines 0 comments Download
M mojo/shell/public/cpp/lib/connection_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/shell/public/cpp/lib/connection_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/shell/public/cpp/shell.h View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/shell/runner/child/native_apptest_target.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/shell_application_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/standalone/android/android_handler.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (6 generated)
Ben Goodger (Google)
4 years, 10 months ago (2016-02-09 00:38:52 UTC) #1
Ben Goodger (Google)
4 years, 10 months ago (2016-02-09 00:38:52 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1681813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1681813002/1
4 years, 10 months ago (2016-02-09 00:41:18 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/178155)
4 years, 10 months ago (2016-02-09 01:15:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1681813002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1681813002/20001
4 years, 10 months ago (2016-02-09 03:38:34 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_rel/builds/19268) linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 10 months ago (2016-02-09 04:12:04 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1681813002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1681813002/40001
4 years, 10 months ago (2016-02-09 05:06:32 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-09 06:57:12 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-02-09 06:58:11 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/123d058c611dbbae160667a0ccbed49785f54f17
Cr-Commit-Position: refs/heads/master@{#374328}

Powered by Google App Engine
This is Rietveld 408576698