device/devices_app/devices_app.cc - Issue 1681813002: Rename Connection::AddService/ConnectToService to Connection::AddInterface/GetInterface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/devices_app/devices_app.cc

Issue 1681813002: Rename Connection::AddService/ConnectToService to Connection::AddInterface/GetInterface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@interface_binder

Patch Set: . Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/mus/render_widget_window_tree_client_factory.cc ('k') | mandoline/services/core_services/core_services_application_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: device/devices_app/devices_app.cc

diff --git a/device/devices_app/devices_app.cc b/device/devices_app/devices_app.cc

index a34064404fa3040b6cfc6a5367b3f25add213a56..8bb9ab9387203ed0ce0837115f906588ba34b8a2 100644

--- a/device/devices_app/devices_app.cc

+++ b/device/devices_app/devices_app.cc

@@ -89,7 +89,7 @@ void DevicesApp::Initialize(mojo::Shell* shell,

}

bool DevicesApp::AcceptConnection(mojo::Connection* connection) {

- connection->AddService<usb::DeviceManager>(this);

+ connection->AddInterface<usb::DeviceManager>(this);

return true;

}

@@ -103,7 +103,7 @@ void DevicesApp::Create(mojo::Connection* connection,

// Bind the new device manager to the connecting application's permission

// provider.

usb::PermissionProviderPtr permission_provider;

- connection->ConnectToService(&permission_provider);

+ connection->GetInterface(&permission_provider);

// Owned by its message pipe.

usb::DeviceManagerImpl* device_manager = new usb::DeviceManagerImpl(