[DevTools] Remove isRunRequired, replace autoConnectToWorkers with setWaitForDebuggerOnStart.

[DevTools] Remove isRunRequired, replace autoConnectToWorkers with setWaitForDebuggerOnStart.

In addition encapsulated InspectorInstrumentation calls in WorkerInspectorProxy and make it responsible for "pause on start" decisions.

Attempt #2. First one was reverted due to crash during termination, which was fixed recently.

BUG=none

Committed: https://crrev.com/48a0e0eea44c193e7a5eb2e1e2e7a8c7d2a5cbdc
Cr-Commit-Position: refs/heads/master@{#379324}

[dgozman, 2016-02-09 01:38:18]

Description was changed from

==========
[DevTools] Remove isRunRequired, replace autoConnectToWorkers with
pauseWorkersOnStart.

Drive-by: encapsulate InspectorInstrumentation calls in WorkerInspectorProxy.

BUG=none
==========

to

==========
[DevTools] Remove isRunRequired, replace autoConnectToWorkers with
pauseWorkersOnStart.

In addition encapsulated InspectorInstrumentation calls in WorkerInspectorProxy
and make it responsible for "pause on start" decisions.

BUG=none
==========

[dgozman, 2016-02-09 01:40:12]

dgozman@chromium.org changed reviewers:
+ pfeldman@chromium.org

[dgozman, 2016-02-09 01:40:13]

Take a look please.

[dgozman, 2016-02-09 01:44:25]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-09 01:46:04]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1679133002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1679133002/20001

[commit-bot: I haz the power, 2016-02-09 03:08:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-09 03:08:18]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[pfeldman, 2016-02-09 22:42:56]

lgtm

https://codereview.chromium.org/1679133002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector-protocol/debugger/debugger-step-into-dedicated-worker.html
(right):

https://codereview.chromium.org/1679133002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector-protocol/debugger/debugger-step-into-dedicated-worker.html:40:
InspectorTest.sendCommand("Worker.setPauseWorkersOnStart", { "value": true });
Worker.setWaitForDebuggerOnStart

https://codereview.chromium.org/1679133002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/workers/WorkerInspectorProxy.cpp (right):

https://codereview.chromium.org/1679133002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/workers/WorkerInspectorProxy.cpp:48: bool
pausedOnStart =
InspectorInstrumentation::shouldPauseDedicatedWorkerOnStart(context);
So you are passing the value you got back into instrumentation? Why is this
necessary?

https://codereview.chromium.org/1679133002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/WorkerManager.js (right):

https://codereview.chromium.org/1679133002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/WorkerManager.js:110: if
(mainIsServiceWorker && pausedOnStart)
So it is not pausedOnStart - it is not yet running, right?

[dgozman, 2016-02-09 23:08:57]

Description was changed from

==========
[DevTools] Remove isRunRequired, replace autoConnectToWorkers with
pauseWorkersOnStart.

In addition encapsulated InspectorInstrumentation calls in WorkerInspectorProxy
and make it responsible for "pause on start" decisions.

BUG=none
==========

to

==========
[DevTools] Remove isRunRequired, replace autoConnectToWorkers with
setWaitForDebuggerOnStart.

In addition encapsulated InspectorInstrumentation calls in WorkerInspectorProxy
and make it responsible for "pause on start" decisions.

BUG=none
==========

[dgozman, 2016-02-09 23:45:28]

https://codereview.chromium.org/1679133002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector-protocol/debugger/debugger-step-into-dedicated-worker.html
(right):

https://codereview.chromium.org/1679133002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector-protocol/debugger/debugger-step-into-dedicated-worker.html:40:
InspectorTest.sendCommand("Worker.setPauseWorkersOnStart", { "value": true });
On 2016/02/09 22:42:56, pfeldman wrote:
> Worker.setWaitForDebuggerOnStart

Done.

https://codereview.chromium.org/1679133002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/workers/WorkerInspectorProxy.cpp (right):

https://codereview.chromium.org/1679133002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/workers/WorkerInspectorProxy.cpp:48: bool
pausedOnStart =
InspectorInstrumentation::shouldPauseDedicatedWorkerOnStart(context);
On 2016/02/09 22:42:56, pfeldman wrote:
> So you are passing the value you got back into instrumentation? Why is this
> necessary?

Otherwise instrumenting agent must assume shouldPauseDedicatedWorkerOnStart()
was called synchronously before.

[dgozman, 2016-02-09 23:45:30]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2016-02-09 23:45:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/1679133002/#ps60001
(title: "fixed review comments")

[commit-bot: I haz the power, 2016-02-09 23:46:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1679133002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1679133002/60001

[commit-bot: I haz the power, 2016-02-10 01:24:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-10 01:24:03]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[dgozman, 2016-02-11 18:54:01]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2016-02-11 18:57:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1679133002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1679133002/60001

[commit-bot: I haz the power, 2016-02-11 21:09:55]

Description was changed from

==========
[DevTools] Remove isRunRequired, replace autoConnectToWorkers with
setWaitForDebuggerOnStart.

In addition encapsulated InspectorInstrumentation calls in WorkerInspectorProxy
and make it responsible for "pause on start" decisions.

BUG=none
==========

to

==========
[DevTools] Remove isRunRequired, replace autoConnectToWorkers with
setWaitForDebuggerOnStart.

In addition encapsulated InspectorInstrumentation calls in WorkerInspectorProxy
and make it responsible for "pause on start" decisions.

BUG=none
==========

[commit-bot: I haz the power, 2016-02-11 21:09:56]

Committed patchset #4 (id:60001)

[dgozman, 2016-02-12 01:09:40]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1692813002/ by dgozman@chromium.org.

The reason for reverting is: Breaks
	http/tests/inspector-enabled/dedicated-workers-list.html.
BUG=586342
.

[commit-bot: I haz the power, 2016-02-16 22:38:02]

Description was changed from

==========
[DevTools] Remove isRunRequired, replace autoConnectToWorkers with
setWaitForDebuggerOnStart.

In addition encapsulated InspectorInstrumentation calls in WorkerInspectorProxy
and make it responsible for "pause on start" decisions.

BUG=none
==========

to

==========
[DevTools] Remove isRunRequired, replace autoConnectToWorkers with
setWaitForDebuggerOnStart.

In addition encapsulated InspectorInstrumentation calls in WorkerInspectorProxy
and make it responsible for "pause on start" decisions.

BUG=none

Committed: https://crrev.com/4e76e5c83f49b8584981635d4040cabf76b41ebf
Cr-Commit-Position: refs/heads/master@{#374985}
==========

[commit-bot: I haz the power, 2016-02-16 22:38:02]

Patchset 4 (id:??) landed as
https://crrev.com/4e76e5c83f49b8584981635d4040cabf76b41ebf
Cr-Commit-Position: refs/heads/master@{#374985}

[dgozman, 2016-03-04 02:19:33]

Description was changed from

==========
[DevTools] Remove isRunRequired, replace autoConnectToWorkers with
setWaitForDebuggerOnStart.

In addition encapsulated InspectorInstrumentation calls in WorkerInspectorProxy
and make it responsible for "pause on start" decisions.

BUG=none

Committed: https://crrev.com/4e76e5c83f49b8584981635d4040cabf76b41ebf
Cr-Commit-Position: refs/heads/master@{#374985}
==========

to

==========
[DevTools] Remove isRunRequired, replace autoConnectToWorkers with
setWaitForDebuggerOnStart.

In addition encapsulated InspectorInstrumentation calls in WorkerInspectorProxy
and make it responsible for "pause on start" decisions.

Attempt #2. First one was reverted due to crash during termination, which was
fixed recently.

BUG=none
==========

[dgozman, 2016-03-04 16:10:48]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2016-03-04 16:10:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/1679133002/#ps80001
(title: "rebased")

[commit-bot: I haz the power, 2016-03-04 16:11:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1679133002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1679133002/80001

[commit-bot: I haz the power, 2016-03-04 16:14:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-04 16:14:21]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[dgozman, 2016-03-04 17:38:31]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2016-03-04 17:38:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/1679133002/#ps100001
(title: "rebased")

[commit-bot: I haz the power, 2016-03-04 17:38:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1679133002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1679133002/100001

[commit-bot: I haz the power, 2016-03-04 19:02:57]

Description was changed from

==========
[DevTools] Remove isRunRequired, replace autoConnectToWorkers with
setWaitForDebuggerOnStart.

In addition encapsulated InspectorInstrumentation calls in WorkerInspectorProxy
and make it responsible for "pause on start" decisions.

Attempt #2. First one was reverted due to crash during termination, which was
fixed recently.

BUG=none
==========

to

==========
[DevTools] Remove isRunRequired, replace autoConnectToWorkers with
setWaitForDebuggerOnStart.

In addition encapsulated InspectorInstrumentation calls in WorkerInspectorProxy
and make it responsible for "pause on start" decisions.

Attempt #2. First one was reverted due to crash during termination, which was
fixed recently.

BUG=none
==========

[commit-bot: I haz the power, 2016-03-04 19:02:58]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-03-04 19:04:32]

Description was changed from

==========
[DevTools] Remove isRunRequired, replace autoConnectToWorkers with
setWaitForDebuggerOnStart.

In addition encapsulated InspectorInstrumentation calls in WorkerInspectorProxy
and make it responsible for "pause on start" decisions.

Attempt #2. First one was reverted due to crash during termination, which was
fixed recently.

BUG=none
==========

to

==========
[DevTools] Remove isRunRequired, replace autoConnectToWorkers with
setWaitForDebuggerOnStart.

In addition encapsulated InspectorInstrumentation calls in WorkerInspectorProxy
and make it responsible for "pause on start" decisions.

Attempt #2. First one was reverted due to crash during termination, which was
fixed recently.

BUG=none

Committed: https://crrev.com/48a0e0eea44c193e7a5eb2e1e2e7a8c7d2a5cbdc
Cr-Commit-Position: refs/heads/master@{#379324}
==========

[commit-bot: I haz the power, 2016-03-04 19:04:33]

Patchset 6 (id:??) landed as
https://crrev.com/48a0e0eea44c193e7a5eb2e1e2e7a8c7d2a5cbdc
Cr-Commit-Position: refs/heads/master@{#379324}