third_party/WebKit/Source/core/workers/WorkerMessagingProxy.cpp - Issue 1679133002: [DevTools] Remove isRunRequired, replace autoConnectToWorkers with setWaitForDebuggerOnStart.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/workers/WorkerMessagingProxy.cpp

Issue 1679133002: [DevTools] Remove isRunRequired, replace autoConnectToWorkers with setWaitForDebuggerOnStart. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/workers/WorkerMessagingProxy.h ('k') | third_party/WebKit/Source/devtools/front_end/sdk/WorkerManager.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/workers/WorkerMessagingProxy.cpp

diff --git a/third_party/WebKit/Source/core/workers/WorkerMessagingProxy.cpp b/third_party/WebKit/Source/core/workers/WorkerMessagingProxy.cpp

index fc40d45f59165adfe561c4180db65945d342322a..21d5c6610d48dcc30743691f5678bdd050ad71e5 100644

--- a/third_party/WebKit/Source/core/workers/WorkerMessagingProxy.cpp

+++ b/third_party/WebKit/Source/core/workers/WorkerMessagingProxy.cpp

@@ -99,7 +99,7 @@ WorkerMessagingProxy::~WorkerMessagingProxy()

m_workerInspectorProxy->setWorkerGlobalScopeProxy(nullptr);

}

-void WorkerMessagingProxy::startWorkerGlobalScope(const KURL& scriptURL, const String& userAgent, const String& sourceCode, WorkerThreadStartMode startMode)

+void WorkerMessagingProxy::startWorkerGlobalScope(const KURL& scriptURL, const String& userAgent, const String& sourceCode)

{

// FIXME: This need to be revisited when we support nested worker one day

ASSERT(m_executionContext->isDocument());

@@ -113,6 +113,7 @@ void WorkerMessagingProxy::startWorkerGlobalScope(const KURL& scriptURL, const S

ContentSecurityPolicy* csp = m_workerObject->contentSecurityPolicy() ? m_workerObject->contentSecurityPolicy() : document->contentSecurityPolicy();

ASSERT(csp);

+ WorkerThreadStartMode startMode = m_workerInspectorProxy->workerStartMode(document);

OwnPtr<WorkerThreadStartupData> startupData = WorkerThreadStartupData::create(scriptURL, userAgent, sourceCode, nullptr, startMode, csp->headers(), starterOrigin, m_workerClients.release(), document->addressSpace());

double originTime = document->loader() ? document->loader()->timing().referenceMonotonicTime() : monotonicallyIncreasingTime();