third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.h - Issue 1679133002: [DevTools] Remove isRunRequired, replace autoConnectToWorkers with setWaitForDebuggerOnStart.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.h

Issue 1679133002: [DevTools] Remove isRunRequired, replace autoConnectToWorkers with setWaitForDebuggerOnStart. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorRuntimeAgent.cpp ('k') | third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.h

diff --git a/third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.h b/third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.h

index 84b0c3dabd9b67434b3a7e8451e838ffe8c5c3d8..508dea806e4dbefec5167873427168342bdb96d7 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.h

+++ b/third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.h

@@ -58,16 +58,14 @@ public:

void didCommitLoadForLocalFrame(LocalFrame*) override;

// Called from InspectorInstrumentation

- bool shouldPauseDedicatedWorkerOnStart();

- void didStartWorker(WorkerInspectorProxy*, const KURL&);

+ bool shouldWaitForDebuggerOnWorkerStart();

+ void didStartWorker(WorkerInspectorProxy*, const KURL&, bool waitingForDebugger);

void workerTerminated(WorkerInspectorProxy*);

// Called from Dispatcher

void enable(ErrorString*) override;

- void connectToWorker(ErrorString*, const String& workerId) override;

- void disconnectFromWorker(ErrorString*, const String& workerId) override;

void sendMessageToWorker(ErrorString*, const String& workerId, const String& message) override;

- void setAutoconnectToWorkers(ErrorString*, bool value) override;

+ void setWaitForDebuggerOnStart(ErrorString*, bool value) override;

void setTracingSessionId(const String&);

@@ -100,7 +98,7 @@ public:

private:

InspectorWorkerAgent(InspectedFrames*, PageConsoleAgent*);

void createWorkerAgentClientsForExistingWorkers();

- void createWorkerAgentClient(WorkerInspectorProxy*, const String& url, const String& id);

+ void createWorkerAgentClient(WorkerInspectorProxy*, const String& url, const String& id, bool waitingForDebugger);

void destroyWorkerAgentClients();

class WorkerInfo {