Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Side by Side Diff: third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp

Issue 1679133002: [DevTools] Remove isRunRequired, replace autoConnectToWorkers with setWaitForDebuggerOnStart. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 167 matching lines...) Expand 10 before | Expand all | Expand 10 after
178 m_injectedScriptManager->releaseObjectGroup(objectGroup); 178 m_injectedScriptManager->releaseObjectGroup(objectGroup);
179 if (pausingOnNextStatement) 179 if (pausingOnNextStatement)
180 m_debugger->setPauseOnNextStatement(true); 180 m_debugger->setPauseOnNextStatement(true);
181 } 181 }
182 182
183 void V8RuntimeAgentImpl::run(ErrorString* errorString) 183 void V8RuntimeAgentImpl::run(ErrorString* errorString)
184 { 184 {
185 *errorString = "Not paused"; 185 *errorString = "Not paused";
186 } 186 }
187 187
188 void V8RuntimeAgentImpl::isRunRequired(ErrorString*, bool* out_result)
189 {
190 *out_result = false;
191 }
192
193 void V8RuntimeAgentImpl::setCustomObjectFormatterEnabled(ErrorString*, bool enab led) 188 void V8RuntimeAgentImpl::setCustomObjectFormatterEnabled(ErrorString*, bool enab led)
194 { 189 {
195 m_state->setBoolean(V8RuntimeAgentImplState::customObjectFormatterEnabled, e nabled); 190 m_state->setBoolean(V8RuntimeAgentImplState::customObjectFormatterEnabled, e nabled);
196 m_injectedScriptManager->setCustomObjectFormatterEnabled(enabled); 191 m_injectedScriptManager->setCustomObjectFormatterEnabled(enabled);
197 } 192 }
198 193
199 void V8RuntimeAgentImpl::compileScript(ErrorString* errorString, 194 void V8RuntimeAgentImpl::compileScript(ErrorString* errorString,
200 const String& expression, 195 const String& expression,
201 const String& sourceURL, 196 const String& sourceURL,
202 bool persistScript, 197 bool persistScript,
(...skipping 227 matching lines...) Expand 10 before | Expand all | Expand 10 after
430 OwnPtr<ExceptionDetails> exceptionDetails = ExceptionDetails::create().setTe xt(toWTFStringWithTypeCheck(message->Get())).build(); 425 OwnPtr<ExceptionDetails> exceptionDetails = ExceptionDetails::create().setTe xt(toWTFStringWithTypeCheck(message->Get())).build();
431 exceptionDetails->setLine(message->GetLineNumber()); 426 exceptionDetails->setLine(message->GetLineNumber());
432 exceptionDetails->setColumn(message->GetStartColumn()); 427 exceptionDetails->setColumn(message->GetStartColumn());
433 v8::Local<v8::StackTrace> messageStackTrace = message->GetStackTrace(); 428 v8::Local<v8::StackTrace> messageStackTrace = message->GetStackTrace();
434 if (!messageStackTrace.IsEmpty() && messageStackTrace->GetFrameCount() > 0) 429 if (!messageStackTrace.IsEmpty() && messageStackTrace->GetFrameCount() > 0)
435 exceptionDetails->setStack(m_debugger->createStackTrace(messageStackTrac e, messageStackTrace->GetFrameCount())->buildInspectorObject()); 430 exceptionDetails->setStack(m_debugger->createStackTrace(messageStackTrac e, messageStackTrace->GetFrameCount())->buildInspectorObject());
436 return exceptionDetails.release(); 431 return exceptionDetails.release();
437 } 432 }
438 433
439 } // namespace blink 434 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698