third_party/WebKit/Source/core/inspector/InspectorRuntimeAgent.h - Issue 1679133002: [DevTools] Remove isRunRequired, replace autoConnectToWorkers with setWaitForDebuggerOnStart.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorRuntimeAgent.h

Issue 1679133002: [DevTools] Remove isRunRequired, replace autoConnectToWorkers with setWaitForDebuggerOnStart. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl ('k') | third_party/WebKit/Source/core/inspector/InspectorRuntimeAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorRuntimeAgent.h

diff --git a/third_party/WebKit/Source/core/inspector/InspectorRuntimeAgent.h b/third_party/WebKit/Source/core/inspector/InspectorRuntimeAgent.h

index 1cf7d36d5c97bb458fb1da2bd390e612afc9f0ce..d82bfc0aecd75eb480340451defdd6b2ca57772a 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorRuntimeAgent.h

+++ b/third_party/WebKit/Source/core/inspector/InspectorRuntimeAgent.h

@@ -63,7 +63,6 @@ public:

virtual ~Client() { }

virtual void resumeStartup() { }

- virtual bool isRunRequired() { return false; }

};

~InspectorRuntimeAgent() override;

@@ -86,7 +85,6 @@ public:

void run(ErrorString*) override;

void enable(ErrorString*) override;

void disable(ErrorString*) override;

- void isRunRequired(ErrorString*, bool* result) override;

void setCustomObjectFormatterEnabled(ErrorString*, bool enabled) override;

void compileScript(ErrorString*, const String& expression, const String& sourceURL, bool persistScript, int executionContextId, Maybe<String>* scriptId, Maybe<protocol::Runtime::ExceptionDetails>*) override;

void runScript(ErrorString*, const String& scriptId, int executionContextId, const Maybe<String>& objectGroup, const Maybe<bool>& doNotPauseOnExceptionsAndMuteConsole, const Maybe<bool>& includeCommandLineAPI, OwnPtr<protocol::Runtime::RemoteObject>* result, Maybe<protocol::Runtime::ExceptionDetails>*) override;