mojom_types.mojom: Changes the name |interface_name| to |service_name| in struct MojomInterface.

mojom_types.mojom: Changes the name |interface_name| to |service_name| in struct MojomInterface.

Also the mojom parser now populates this field with the correct service name (that is, the value of the "ServiceName" attribute) if it is set. The field was changed to nullable and will be unset if the interface does not have the attribute.

We removed the logic from mojom_translator.py that gets the service name from the "ServiceName" attribute and instead get it from the service_name field (which was set to the value in the "ServiceName" attribute in the parser.) The
interface_name field of mojom.Interface is now obtained from the decl_data.short_name field. Previously it was obtained from the interface_name field (which was set to the value of decl_data.short_name in the parser.)

BUG=#448
R=azani@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/de0d6c66f4208bdaeec3ef1cfa76d5ee1c4c7428

[rudominer, 2016-02-09 02:05:52]

Description was changed from

==========
Mojom compiler: Changes the name of the field |interface_name| to |service_name|
in the MojomInterface struct in mojom_types.mojom.

BUG=
==========

to

==========
Mojom compiler: Changes the name of the field |interface_name| to |service_name|
in the MojomInterface struct in mojom_types.mojom.

BUG=#448
==========

[rudominer, 2016-02-09 02:09:34]

Description was changed from

==========
Mojom compiler: Changes the name of the field |interface_name| to |service_name|
in the MojomInterface struct in mojom_types.mojom.

BUG=#448
==========

to

==========
mojom_types.mojom: Changes the name |interface_name| to |service_name| in struct
MojomInterface.

Also the mojom parser now populates this field with the correct service name
(that is, the value of the "ServiceName" attributes) if it is set. The field was
changed to nullable and will be unset of the interface does not have the
attribute.

BUG=#448
==========

[rudominer, 2016-02-09 02:10:27]

Description was changed from

==========
mojom_types.mojom: Changes the name |interface_name| to |service_name| in struct
MojomInterface.

Also the mojom parser now populates this field with the correct service name
(that is, the value of the "ServiceName" attributes) if it is set. The field was
changed to nullable and will be unset of the interface does not have the
attribute.

BUG=#448
==========

to

==========
mojom_types.mojom: Changes the name |interface_name| to |service_name| in struct
MojomInterface.

Also the mojom parser now populates this field with the correct service name
(that is, the value of the "ServiceName" attribute) if it is set. The field was
changed to nullable and will be unset of the interface does not have the
attribute.

BUG=#448
==========

[rudominer, 2016-02-09 17:34:51]

Description was changed from

==========
mojom_types.mojom: Changes the name |interface_name| to |service_name| in struct
MojomInterface.

Also the mojom parser now populates this field with the correct service name
(that is, the value of the "ServiceName" attribute) if it is set. The field was
changed to nullable and will be unset of the interface does not have the
attribute.

BUG=#448
==========

to

==========
mojom_types.mojom: Changes the name |interface_name| to |service_name| in struct
MojomInterface.

Also the mojom parser now populates this field with the correct service name
(that is, the value of the "ServiceName" attribute) if it is set. The field was
changed to nullable and will be unset if the interface does not have the
attribute.

We removed the logic from mojom_translator.py that gets the service name from
the "ServiceName" attribute and instead get it from the service_name field
(which was set to the value in the "ServiceName" attribute in the parser.) 

BUG=#448
==========

[rudominer, 2016-02-09 17:37:14]

Patchset #1 (id:1) has been deleted

[rudominer, 2016-02-09 17:37:21]

Patchset #1 (id:20001) has been deleted

[rudominer, 2016-02-09 17:37:30]

Patchset #1 (id:40001) has been deleted

[rudominer, 2016-02-09 17:37:36]

Patchset #1 (id:60001) has been deleted

[rudominer, 2016-02-09 17:37:45]

Patchset #1 (id:80001) has been deleted

[rudominer, 2016-02-09 17:37:53]

Patchset #1 (id:100001) has been deleted

[rudominer, 2016-02-09 17:38:00]

Patchset #1 (id:120001) has been deleted

[rudominer, 2016-02-09 17:40:59]

Description was changed from

==========
mojom_types.mojom: Changes the name |interface_name| to |service_name| in struct
MojomInterface.

Also the mojom parser now populates this field with the correct service name
(that is, the value of the "ServiceName" attribute) if it is set. The field was
changed to nullable and will be unset if the interface does not have the
attribute.

We removed the logic from mojom_translator.py that gets the service name from
the "ServiceName" attribute and instead get it from the service_name field
(which was set to the value in the "ServiceName" attribute in the parser.) 

BUG=#448
==========

to

==========
mojom_types.mojom: Changes the name |interface_name| to |service_name| in struct
MojomInterface.

Also the mojom parser now populates this field with the correct service name
(that is, the value of the "ServiceName" attribute) if it is set. The field was
changed to nullable and will be unset if the interface does not have the
attribute.

We removed the logic from mojom_translator.py that gets the service name from
the "ServiceName" attribute and instead get it from the service_name field
(which was set to the value in the "ServiceName" attribute in the parser.) The
interface_name field of mojom.Interface is now obtained from the
decl_data.short_name field. Previously it was obtained from the interface_name
field (which was set to the value of decl_data.short_name in the parser.)

BUG=#448
==========

[rudominer, 2016-02-09 22:40:55]

Patchset #1 (id:140001) has been deleted

[rudominer, 2016-02-09 22:41:13]

Patchset #2 (id:180001) has been deleted

[rudominer, 2016-02-09 22:41:23]

Patchset #2 (id:200001) has been deleted

[rudominer, 2016-02-09 22:41:43]

Patchset #1 (id:160001) has been deleted

[rudominer, 2016-02-09 22:42:16]

rudominer@chromium.org changed reviewers:
+ azani@chromium.org

[rudominer, 2016-02-09 22:42:17]

Hi Alex, ptal.

[azani, 2016-02-10 00:06:39]

https://codereview.chromium.org/1677343002/diff/220001/mojo/public/tools/bind...
File mojo/public/tools/bindings/generators/dart_templates/mojom_type_macros.tmpl
(right):

https://codereview.chromium.org/1677343002/diff/220001/mojo/public/tools/bind...
mojo/public/tools/bindings/generators/dart_templates/mojom_type_macros.tmpl:24:
..serviceName_ = '{{type|name}}'
This changes the name in dart bindings. Is that what you meant to do and why?

https://codereview.chromium.org/1677343002/diff/220001/mojo/public/tools/bind...
File mojo/public/tools/bindings/pylib/mojom/generate/mojom_translator.py
(right):

https://codereview.chromium.org/1677343002/diff/220001/mojo/public/tools/bind...
mojo/public/tools/bindings/pylib/mojom/generate/mojom_translator.py:404: assert
interface.service_name == None, interface.service_name
standard python practice is to use: is None instead of == None.

https://codereview.chromium.org/1677343002/diff/220001/mojom/mojom_parser/moj...
File mojom/mojom_parser/mojom/user_defined_types.go (right):

https://codereview.chromium.org/1677343002/diff/220001/mojom/mojom_parser/moj...
mojom/mojom_parser/mojom/user_defined_types.go:554: const serviceNameAttribute =
"ServiceName"
Given that it's used in only one location, I don't think this constant is
necessary.

[rudominer, 2016-02-10 00:43:49]

ptal

https://codereview.chromium.org/1677343002/diff/220001/mojo/public/tools/bind...
File mojo/public/tools/bindings/generators/dart_templates/mojom_type_macros.tmpl
(right):

https://codereview.chromium.org/1677343002/diff/220001/mojo/public/tools/bind...
mojo/public/tools/bindings/generators/dart_templates/mojom_type_macros.tmpl:24:
..serviceName_ = '{{type|name}}'
On 2016/02/10 00:06:39, azani wrote:
> This changes the name in dart bindings. Is that what you meant to do and why?

This is changing the name in the generated code that invokes other generated
code in which the name has been changed--so this was necessary.

https://codereview.chromium.org/1677343002/diff/220001/mojo/public/tools/bind...
File mojo/public/tools/bindings/pylib/mojom/generate/mojom_translator.py
(right):

https://codereview.chromium.org/1677343002/diff/220001/mojo/public/tools/bind...
mojo/public/tools/bindings/pylib/mojom/generate/mojom_translator.py:404: assert
interface.service_name == None, interface.service_name
On 2016/02/10 00:06:39, azani wrote:
> standard python practice is to use: is None instead of == None.

Done.

https://codereview.chromium.org/1677343002/diff/220001/mojom/mojom_parser/moj...
File mojom/mojom_parser/mojom/user_defined_types.go (right):

https://codereview.chromium.org/1677343002/diff/220001/mojom/mojom_parser/moj...
mojom/mojom_parser/mojom/user_defined_types.go:554: const serviceNameAttribute =
"ServiceName"
On 2016/02/10 00:06:39, azani wrote:
> Given that it's used in only one location, I don't think this constant is
> necessary.

Done.

[azani, 2016-02-10 00:57:11]

lgtm

[rudominer, 2016-02-10 00:59:09]

Description was changed from

==========
mojom_types.mojom: Changes the name |interface_name| to |service_name| in struct
MojomInterface.

Also the mojom parser now populates this field with the correct service name
(that is, the value of the "ServiceName" attribute) if it is set. The field was
changed to nullable and will be unset if the interface does not have the
attribute.

We removed the logic from mojom_translator.py that gets the service name from
the "ServiceName" attribute and instead get it from the service_name field
(which was set to the value in the "ServiceName" attribute in the parser.) The
interface_name field of mojom.Interface is now obtained from the
decl_data.short_name field. Previously it was obtained from the interface_name
field (which was set to the value of decl_data.short_name in the parser.)

BUG=#448
==========

to

==========
mojom_types.mojom: Changes the name |interface_name| to |service_name| in struct
MojomInterface.

Also the mojom parser now populates this field with the correct service name
(that is, the value of the "ServiceName" attribute) if it is set. The field was
changed to nullable and will be unset if the interface does not have the
attribute.

We removed the logic from mojom_translator.py that gets the service name from
the "ServiceName" attribute and instead get it from the service_name field
(which was set to the value in the "ServiceName" attribute in the parser.) The
interface_name field of mojom.Interface is now obtained from the
decl_data.short_name field. Previously it was obtained from the interface_name
field (which was set to the value of decl_data.short_name in the parser.)

BUG=#448
R=azani@chromium.org

Committed:
https://chromium.googlesource.com/external/mojo/+/de0d6c66f4208bdaeec3ef1cfa7...
==========

[rudominer, 2016-02-10 00:59:10]

Committed patchset #2 (id:240001) manually as
de0d6c66f4208bdaeec3ef1cfa76d5ee1c4c7428 (presubmit successful).