Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Unified Diff: mojo/dart/packages/mojo/lib/mojo/bindings/types/mojom_types.mojom.dart

Issue 1677343002: mojom_types.mojom: Changes the name |interface_name| to |service_name| in struct MojomInterface. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Responds to code review. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/dart/packages/mojo/lib/mojo/bindings/types/mojom_types.mojom.dart
diff --git a/mojo/dart/packages/mojo/lib/mojo/bindings/types/mojom_types.mojom.dart b/mojo/dart/packages/mojo/lib/mojo/bindings/types/mojom_types.mojom.dart
index 75533307dcc483fd52a66168c91ea485f60841d8..a97fa5168c4c9a4ea9e8eafd590587bcc7ff42b9 100644
--- a/mojo/dart/packages/mojo/lib/mojo/bindings/types/mojom_types.mojom.dart
+++ b/mojo/dart/packages/mojo/lib/mojo/bindings/types/mojom_types.mojom.dart
@@ -1763,7 +1763,7 @@ class MojomInterface extends bindings.Struct {
const bindings.StructDataHeader(32, 0)
];
DeclarationData declData = null;
- String interfaceName = null;
+ String serviceName_ = null;
Map<int, MojomMethod> methods = null;
MojomInterface() : super(kVersions.last.size);
@@ -1808,7 +1808,7 @@ class MojomInterface extends bindings.Struct {
}
if (mainDataHeader.version >= 0) {
- result.interfaceName = decoder0.decodeString(16, false);
+ result.serviceName_ = decoder0.decodeString(16, true);
}
if (mainDataHeader.version >= 0) {
@@ -1851,10 +1851,10 @@ class MojomInterface extends bindings.Struct {
rethrow;
}
try {
- encoder0.encodeString(interfaceName, 16, false);
+ encoder0.encodeString(serviceName_, 16, true);
} on bindings.MojoCodecError catch(e) {
e.message = "Error encountered while encoding field "
- "interfaceName of struct MojomInterface: $e";
+ "serviceName_ of struct MojomInterface: $e";
rethrow;
}
try {
@@ -1884,14 +1884,14 @@ class MojomInterface extends bindings.Struct {
String toString() {
return "MojomInterface("
"declData: $declData" ", "
- "interfaceName: $interfaceName" ", "
+ "serviceName_: $serviceName_" ", "
"methods: $methods" ")";
}
Map toJson() {
Map map = new Map();
map["declData"] = declData;
- map["interfaceName"] = interfaceName;
+ map["serviceName_"] = serviceName_;
map["methods"] = methods;
return map;
}

Powered by Google App Engine
This is Rietveld 408576698