mojo/dart/packages/_mojo_for_test_only/lib/test/echo_service.mojom.dart - Issue 1677343002: mojom_types.mojom: Changes the name |interface_name| to |service_name| in struct MojomInterface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/dart/packages/_mojo_for_test_only/lib/test/echo_service.mojom.dart

Issue 1677343002: mojom_types.mojom: Changes the name |interface_name| to |service_name| in struct MojomInterface. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Responds to code review. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/dart/packages/_mojo_for_test_only/lib/sample/sample_service.mojom.dart ('k') | mojo/dart/packages/_mojo_for_test_only/lib/test/pingpong_service.mojom.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/dart/packages/_mojo_for_test_only/lib/test/echo_service.mojom.dart

diff --git a/mojo/dart/packages/_mojo_for_test_only/lib/test/echo_service.mojom.dart b/mojo/dart/packages/_mojo_for_test_only/lib/test/echo_service.mojom.dart

index 5a254c101d49edb9a7323ad5988ed48ad5311984..7e5992fa3da274cd5573f30c02e2ac6bbc56c07a 100644

--- a/mojo/dart/packages/_mojo_for_test_only/lib/test/echo_service.mojom.dart

+++ b/mojo/dart/packages/_mojo_for_test_only/lib/test/echo_service.mojom.dart

@@ -456,7 +456,7 @@ mojom_types.MojomInterface _echoServiceEchoService() {

..declData = (new mojom_types.DeclarationData()

..shortName = 'EchoService'

..fullIdentifier = 'test.EchoService')

- ..interfaceName = 'EchoService'

+ ..serviceName_ = 'EchoService'

..methods = <int, mojom_types.MojomMethod>{

_EchoService_echoStringName: new mojom_types.MojomMethod()

..declData = (new mojom_types.DeclarationData()