mojom/mojom_parser/serialization/serialization.go - Issue 1677343002: mojom_types.mojom: Changes the name |interface_name| to |service_name| in struct MojomInterface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojom/mojom_parser/serialization/serialization.go

Issue 1677343002: mojom_types.mojom: Changes the name |interface_name| to |service_name| in struct MojomInterface. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Responds to code review. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojom/mojom_parser/serialization/serialization.go

diff --git a/mojom/mojom_parser/serialization/serialization.go b/mojom/mojom_parser/serialization/serialization.go

index 332551641d42790aa1632ba66aa5cb2455868e8a..6290c719ddaa4af4b32f2f5b72bd56abedfec287 100644

--- a/mojom/mojom_parser/serialization/serialization.go

+++ b/mojom/mojom_parser/serialization/serialization.go

@@ -208,8 +208,7 @@ func translateMojomInterface(intrfc *mojom.MojomInterface) *mojom_types.UserDefi

mojomInterface.Value.DeclData = translateDeclarationData(&intrfc.DeclarationData)

mojomInterface.Value.DeclData.ContainedDeclarations = translateContainedDeclarations(&intrfc.NestedDeclarations)

- // TODO(rudominer) The Interface name field need not be the name from the .mojom file.

- mojomInterface.Value.InterfaceName = intrfc.SimpleName()

+ mojomInterface.Value.ServiceName = intrfc.ServiceName

mojomInterface.Value.Methods = make(map[uint32]mojom_types.MojomMethod)

for ordinal, method := range intrfc.MethodsByOrdinal {

« no previous file with comments | « mojom/mojom_parser/mojom/user_defined_types.go ('k') | mojom/mojom_parser/serialization/serialization_test.go » ('j') | no next file with comments »