Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: mojo/public/interfaces/bindings/mojom_types.mojom

Issue 1677343002: mojom_types.mojom: Changes the name |interface_name| to |service_name| in struct MojomInterface. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Responds to code review. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/interfaces/bindings/mojom_types.mojom
diff --git a/mojo/public/interfaces/bindings/mojom_types.mojom b/mojo/public/interfaces/bindings/mojom_types.mojom
index 6d8d7a82ecee5683179bfdf9aa30d36f987066f4..c0365597c69fce30a09c4c4e461909f9dca7a56a 100644
--- a/mojo/public/interfaces/bindings/mojom_types.mojom
+++ b/mojo/public/interfaces/bindings/mojom_types.mojom
@@ -262,10 +262,15 @@ struct MojomMethod {
struct MojomInterface {
DeclarationData? decl_data;
- // By definition, the name of an interface is the string that would be passed
- // to the method ServiceProvider.ConnectToService() in order obtain a
- // connection to the interface.
- string interface_name;
+ // If the declaration of this interface has been annotated with the
+ // "ServiceName=" attribute then this field contains the value of that
+ // attribute, otherwise this is null. The presence of this field indicates
+ // that this is the top-level interface for the named service: When
+ // the method ConnectToService(service_name) from the ServiceProvider
+ // interface is invoked, an implementation of ServiceProvider will, by
+ // default, return the interface that has been annotated with the
+ // given service_name if there is a unique such interface.
+ string? service_name;
// All the methods in the interface. The keys are the method ordinals.
map<uint32, MojomMethod> methods;

Powered by Google App Engine
This is Rietveld 408576698