1. Fix memory leaks reported by running a simple test using ASAN

1. Fix memory leaks reported by running a simple test using ASAN
2. Get rid of some methods in cpuninfo that are not being used anymore and make some methods private.

R=zra@google.com

Committed: https://github.com/dart-lang/sdk/commit/579299613046270d507070907515bb3dbdb5385d

[siva, 2016-02-09 16:34:13]

asiva@google.com changed reviewers:
+ zra@google.com

[zra, 2016-02-09 16:50:53]

lgtm with small fix

https://codereview.chromium.org/1677043003/diff/1/runtime/vm/cpuinfo_macos.cc
File runtime/vm/cpuinfo_macos.cc (right):

https://codereview.chromium.org/1677043003/diff/1/runtime/vm/cpuinfo_macos.cc...
runtime/vm/cpuinfo_macos.cc:63: char* result = new char[result_len];
This gets free()'d, so it should probably be a malloc().

[siva, 2016-02-09 18:09:12]

https://codereview.chromium.org/1677043003/diff/1/runtime/vm/cpuinfo_macos.cc
File runtime/vm/cpuinfo_macos.cc (right):

https://codereview.chromium.org/1677043003/diff/1/runtime/vm/cpuinfo_macos.cc...
runtime/vm/cpuinfo_macos.cc:63: char* result = new char[result_len];
On 2016/02/09 16:50:52, zra wrote:
> This gets free()'d, so it should probably be a malloc().

Done.

[siva, 2016-02-09 18:54:36]

Description was changed from

==========
1. Fix memory leaks reported by running a simple test using ASAN
2. Get rid of some methods in cpuninfo that are not being used anymore and make
some methods private.
==========

to

==========
1. Fix memory leaks reported by running a simple test using ASAN
2. Get rid of some methods in cpuninfo that are not being used anymore and make
some methods private.

R=zra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/579299613046270d507070907515bb3dbdb5385d
==========

[siva, 2016-02-09 18:54:37]

Committed patchset #2 (id:20001) manually as
579299613046270d507070907515bb3dbdb5385d (presubmit successful).