runtime/vm/cpuinfo_test.cc - Issue 1677043003: 1. Fix memory leaks reported by running a simple test using ASAN

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: runtime/vm/cpuinfo_test.cc

Issue 1677043003: 1. Fix memory leaks reported by running a simple test using ASAN (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: address-code-review Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file	1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file

2 // for details. All rights reserved. Use of this source code is governed by a	2 // for details. All rights reserved. Use of this source code is governed by a

3 // BSD-style license that can be found in the LICENSE file.	3 // BSD-style license that can be found in the LICENSE file.

4	4

5 #include "platform/assert.h"	5 #include "platform/assert.h"

6 #include "vm/cpuinfo.h"	6 #include "vm/cpuinfo.h"

7 #include "vm/globals.h"	7 #include "vm/globals.h"

8 #include "vm/unit_test.h"	8 #include "vm/unit_test.h"

9	9

10 namespace dart {	10 namespace dart {

11	11

12 UNIT_TEST_CASE(GetCpuModelTest) {	12 UNIT_TEST_CASE(GetCpuModelTest) {

13 const char* cpumodel = CpuInfo::GetCpuModel();	13 const char* cpumodel = CpuInfo::GetCpuModel();

14 EXPECT_NE(strlen(cpumodel), 0UL);	14 EXPECT_NE(strlen(cpumodel), 0UL);

	15 // caller is responsible for deleting the returned cpumodel string.

	16 free(const_cast<char*>(cpumodel));

15 }	17 }

16	18

17 } // namespace dart	19 } // namespace dart

OLD	NEW

« no previous file with comments | « runtime/vm/cpuinfo_macos.cc ('k') | runtime/vm/cpuinfo_win.cc » ('j') | no next file with comments »