Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1680)

Unified Diff: runtime/vm/cpuinfo_win.cc

Issue 1677043003: 1. Fix memory leaks reported by running a simple test using ASAN (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: address-code-review Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/cpuinfo_test.cc ('k') | runtime/vm/thread.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/cpuinfo_win.cc
diff --git a/runtime/vm/cpuinfo_win.cc b/runtime/vm/cpuinfo_win.cc
index b648566c5d8799fb04c1e134598bdcb408d443ce..1570af7c64d2a5d9fd81775aa6e69bc249163283 100644
--- a/runtime/vm/cpuinfo_win.cc
+++ b/runtime/vm/cpuinfo_win.cc
@@ -43,37 +43,12 @@ bool CpuInfo::FieldContains(CpuInfoIndices idx, const char* search_string) {
}
-bool CpuInfo::FieldContainsByString(const char* field,
- const char* search_string) {
- ASSERT(method_ != kCpuInfoDefault);
- for (int i = 0; i < kCpuInfoMax; i++) {
- if (strcmp(field, fields_[i]) == 0) {
- return FieldContains(static_cast<CpuInfoIndices>(i), search_string);
- }
- }
- UNIMPLEMENTED();
- return false;
-}
-
-
const char* CpuInfo::ExtractField(CpuInfoIndices idx) {
ASSERT(method_ != kCpuInfoDefault);
return CpuId::field(idx);
}
-const char* CpuInfo::ExtractFieldByString(const char* field) {
- ASSERT(method_ != kCpuInfoDefault);
- for (int i = 0; i < kCpuInfoMax; i++) {
- if (strcmp(field, fields_[i]) == 0) {
- return ExtractField(static_cast<CpuInfoIndices>(i));
- }
- }
- UNIMPLEMENTED();
- return NULL;
-}
-
-
bool CpuInfo::HasField(const char* field) {
ASSERT(method_ != kCpuInfoDefault);
return (strcmp(field, fields_[kCpuInfoProcessor]) == 0) ||
« no previous file with comments | « runtime/vm/cpuinfo_test.cc ('k') | runtime/vm/thread.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698