Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Unified Diff: runtime/vm/cpuinfo.h

Issue 1677043003: 1. Fix memory leaks reported by running a simple test using ASAN (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: address-code-review Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/cpuid.h ('k') | runtime/vm/cpuinfo_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/cpuinfo.h
diff --git a/runtime/vm/cpuinfo.h b/runtime/vm/cpuinfo.h
index cd1247ea22b8600b9cfb205502863a205c5d7f16..95b6ec3c6148937d60a755087a591907c38bc99f 100644
--- a/runtime/vm/cpuinfo.h
+++ b/runtime/vm/cpuinfo.h
@@ -45,16 +45,10 @@ class CpuInfo : public AllStatic {
// Returns true if the cpuinfo field contains the string.
static bool FieldContains(CpuInfoIndices idx, const char* search_string);
- static bool FieldContainsByString(
- const char* field, const char* search_string);
// Returns true if the cpuinfo field [field] exists and is non-empty.
static bool HasField(const char* field);
- // Returns the field. Caller is responsible for freeing the result.
- static const char* ExtractField(CpuInfoIndices idx);
- static const char* ExtractFieldByString(const char* field);
-
// Returns the field describing the CPU model. Caller is responsible for
// freeing the result.
static const char* GetCpuModel() {
@@ -66,6 +60,9 @@ class CpuInfo : public AllStatic {
}
private:
+ // Returns the field. Caller is responsible for freeing the result.
+ static const char* ExtractField(CpuInfoIndices idx);
+
// The method to use to acquire info about the CPU.
static CpuInfoMethod method_;
« no previous file with comments | « runtime/vm/cpuid.h ('k') | runtime/vm/cpuinfo_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698