runtime/vm/cpuinfo_test.cc - Issue 1677043003: 1. Fix memory leaks reported by running a simple test using ASAN

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/cpuinfo_test.cc

Issue 1677043003: 1. Fix memory leaks reported by running a simple test using ASAN (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: address-code-review Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/cpuinfo_test.cc

diff --git a/runtime/vm/cpuinfo_test.cc b/runtime/vm/cpuinfo_test.cc

index 860c407601276b3ca1538354599609b857c04216..0b6113b75b9b2567d510f76454ee8777237f2011 100644

--- a/runtime/vm/cpuinfo_test.cc

+++ b/runtime/vm/cpuinfo_test.cc

@@ -12,6 +12,8 @@ namespace dart {

UNIT_TEST_CASE(GetCpuModelTest) {

const char* cpumodel = CpuInfo::GetCpuModel();

EXPECT_NE(strlen(cpumodel), 0UL);

+ // caller is responsible for deleting the returned cpumodel string.

+ free(const_cast<char*>(cpumodel));

}

} // namespace dart

« no previous file with comments | « runtime/vm/cpuinfo_macos.cc ('k') | runtime/vm/cpuinfo_win.cc » ('j') | no next file with comments »