UniformMatrix* supports transpose is true in ES3 semantic

UniformMatrix* supports transpose is true in ES3 semantic

BUG=429053
Committed: https://crrev.com/7e5601748339cbe7943b0c0ec1f8333415e1d431
Cr-Commit-Position: refs/heads/master@{#374676}

[qiankun, 2016-02-05 17:15:49]

Patchset #1 (id:1) has been deleted

[qiankun, 2016-02-05 17:19:00]

qiankun.miao@intel.com changed reviewers:
+ bajones@chromium.org, kbr@chromium.org, yunchao.he@intel.com, zmo@chromium.org

[qiankun, 2016-02-05 17:19:00]

PTAL. ES3 spec allows transpose argument to be true now.

[Zhenyao Mo, 2016-02-05 17:32:00]

lgtm

https://codereview.chromium.org/1674573002/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/gles2_cmd_decoder_unittest_2.cc (right):

https://codereview.chromium.org/1674573002/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_decoder_unittest_2.cc:248: cmd.Init(1, 2,
false, &data[0][0]);
Here you should also test with transpose == true and INVALID_VALUE is generated.
Also the below two cases.

[qiankun, 2016-02-06 03:02:56]

https://codereview.chromium.org/1674573002/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/gles2_cmd_decoder_unittest_2.cc (right):

https://codereview.chromium.org/1674573002/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_decoder_unittest_2.cc:248: cmd.Init(1, 2,
false, &data[0][0]);
On 2016/02/05 17:31:59, Zhenyao Mo wrote:
> Here you should also test with transpose == true and INVALID_VALUE is
generated.
> Also the below two cases.

Added test cases for gles2. Removed duplicate test cases under if
(es3_enabled).{}, because test cases here will be executed both in gles2 and
gles3 context.

[qiankun, 2016-02-10 00:40:17]

The CQ bit was checked by qiankun.miao@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-10 00:40:52]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1674573002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1674573002/40001

[commit-bot: I haz the power, 2016-02-10 02:24:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-10 02:24:04]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[qiankun, 2016-02-10 17:19:42]

The CQ bit was checked by qiankun.miao@intel.com

[qiankun, 2016-02-10 17:19:43]

The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org
Link to the patchset: https://codereview.chromium.org/1674573002/#ps40001
(title: "remove unused code and add more unittests")

[commit-bot: I haz the power, 2016-02-10 17:21:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1674573002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1674573002/40001

[commit-bot: I haz the power, 2016-02-10 17:32:22]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-02-10 17:33:30]

Description was changed from

==========
UniformMatrix* supports transpose is true in ES3 semantic

BUG=429053
==========

to

==========
UniformMatrix* supports transpose is true in ES3 semantic

BUG=429053

Committed: https://crrev.com/7e5601748339cbe7943b0c0ec1f8333415e1d431
Cr-Commit-Position: refs/heads/master@{#374676}
==========

[commit-bot: I haz the power, 2016-02-10 17:33:31]

Patchset 2 (id:??) landed as
https://crrev.com/7e5601748339cbe7943b0c0ec1f8333415e1d431
Cr-Commit-Position: refs/heads/master@{#374676}