Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: gpu/command_buffer/build_gles2_cmd_buffer.py

Issue 1674573002: UniformMatrix* supports transpose is true in ES3 semantic (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove unused code and add more unittests Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gpu/command_buffer/client/gles2_cmd_helper_autogen.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/build_gles2_cmd_buffer.py
diff --git a/gpu/command_buffer/build_gles2_cmd_buffer.py b/gpu/command_buffer/build_gles2_cmd_buffer.py
index 52cbed159091fe09c33895bc490c0b202aa6e352..137516f40c5454a6be438b9c58da4a608a19cd87 100755
--- a/gpu/command_buffer/build_gles2_cmd_buffer.py
+++ b/gpu/command_buffer/build_gles2_cmd_buffer.py
@@ -2233,16 +2233,6 @@ _NAMED_TYPE_INFO = {
'5',
],
},
- 'FalseOnly': {
- 'type': 'GLboolean',
- 'is_complete': True,
- 'valid': [
- 'false',
- ],
- 'invalid': [
- 'true',
- ],
- },
'ResetStatus': {
'type': 'GLenum',
'is_complete': True,
@@ -3861,6 +3851,7 @@ _FUNCTION_INFO = {
'type': 'PUTn',
'count': 4,
'decoder_func': 'DoUniformMatrix2fv',
+ 'unit_test': False,
},
'UniformMatrix2x3fv': {
'type': 'PUTn',
@@ -3878,6 +3869,7 @@ _FUNCTION_INFO = {
'type': 'PUTn',
'count': 9,
'decoder_func': 'DoUniformMatrix3fv',
+ 'unit_test': False,
},
'UniformMatrix3x2fv': {
'type': 'PUTn',
@@ -3895,6 +3887,7 @@ _FUNCTION_INFO = {
'type': 'PUTn',
'count': 16,
'decoder_func': 'DoUniformMatrix4fv',
+ 'unit_test': False,
},
'UniformMatrix4x2fv': {
'type': 'PUTn',
@@ -8980,8 +8973,7 @@ class SizeNotNegativeArgument(SizeArgument):
class EnumBaseArgument(Argument):
- """Base class for EnumArgument, IntArgument, BitfieldArgument, and
- ValidatedBoolArgument."""
+ """Base class for EnumArgument, IntArgument, and BitfieldArgument."""
def __init__(self, name, gl_type, type, gl_error):
Argument.__init__(self, name, gl_type)
@@ -9103,21 +9095,6 @@ class IntArgument(EnumBaseArgument):
EnumBaseArgument.__init__(self, name, "GLint", type, "GL_INVALID_VALUE")
-class ValidatedBoolArgument(EnumBaseArgument):
- """A class for a GLboolean argument that can only accept specific values.
-
- For example glUniformMatrix takes a GLboolean for it's transpose but it
- must be false.
- """
-
- def __init__(self, name, type):
- EnumBaseArgument.__init__(self, name, "GLboolean", type, "GL_INVALID_VALUE")
-
- def GetLogArg(self):
- """Overridden from Argument."""
- return 'GLES2Util::GetStringBool(%s)' % self.name
-
-
class BitFieldArgument(EnumBaseArgument):
"""A class for a GLbitfield argument that can only accept specific values.
@@ -10112,8 +10089,6 @@ def CreateArg(arg_string):
return EnumArgument(arg_name, arg_type)
elif t.startswith('GLbitfield') and t != 'GLbitfield':
return BitFieldArgument(arg_name, arg_type)
- elif t.startswith('GLboolean') and t != 'GLboolean':
- return ValidatedBoolArgument(arg_name, arg_type)
elif t.startswith('GLboolean'):
return BoolArgument(arg_name, arg_type)
elif t.startswith('GLintUniformLocation'):
« no previous file with comments | « no previous file | gpu/command_buffer/client/gles2_cmd_helper_autogen.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698