Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 1663833002: Make helper function on GrGLSLProgramDataManager non virtual (Closed)

Created:
4 years, 10 months ago by egdaniel
Modified:
4 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -19 lines) Patch
M gyp/gpu.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/gl/GrGLProgramDataManager.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLProgramDataManager.cpp View 1 chunk +0 lines, -15 lines 0 comments Download
M src/gpu/glsl/GrGLSLProgramDataManager.h View 1 chunk +1 line, -1 line 0 comments Download
A src/gpu/glsl/GrGLSLProgramDataManager.cpp View 1 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
egdaniel
ptal
4 years, 10 months ago (2016-02-03 15:54:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1663833002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1663833002/20001
4 years, 10 months ago (2016-02-03 15:54:56 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 10 months ago (2016-02-03 15:54:56 UTC) #6
joshualitt
On 2016/02/03 15:54:56, commit-bot: I haz the power wrote: > Note for Reviewers: > The ...
4 years, 10 months ago (2016-02-03 16:08:20 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 17:52:54 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/2829bb7b9e0b964338758e1511a6b35fcda86a0e

Powered by Google App Engine
This is Rietveld 408576698