Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 1654953003: [Interpreter] Mark flaky Ignition tests as PASS, FAIL. (Closed)

Created:
4 years, 10 months ago by rmcilroy
Modified:
4 years, 10 months ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Mark flaky Ignition tests as PASS, FAIL. Fixes issues with linux64_debug and arm64_sim bots. BUG=v8:4280, v8:4680 LOG=N TBR=machenbach@chromium.org NOTRY=true Committed: https://crrev.com/e66ef888aac265920833395472940e5c9ebc872d Cr-Commit-Position: refs/heads/master@{#33672}

Patch Set 1 #

Total comments: 2

Messages

Total messages: 7 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1654953003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1654953003/1
4 years, 10 months ago (2016-02-02 11:11:56 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-02 11:14:41 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e66ef888aac265920833395472940e5c9ebc872d Cr-Commit-Position: refs/heads/master@{#33672}
4 years, 10 months ago (2016-02-02 11:20:42 UTC) #5
Michael Achenbach
lgtm https://codereview.chromium.org/1654953003/diff/1/test/cctest/cctest.status File test/cctest/cctest.status (right): https://codereview.chromium.org/1654953003/diff/1/test/cctest/cctest.status#newcode726 test/cctest/cctest.status:726: # TODO(rmcilroy,4680): Flaky failures. Not sure if they ...
4 years, 10 months ago (2016-02-02 11:26:10 UTC) #6
rmcilroy
4 years, 10 months ago (2016-02-02 14:19:52 UTC) #7
Message was sent while issue was closed.
https://codereview.chromium.org/1654953003/diff/1/test/cctest/cctest.status
File test/cctest/cctest.status (right):

https://codereview.chromium.org/1654953003/diff/1/test/cctest/cctest.status#n...
test/cctest/cctest.status:726: # TODO(rmcilroy,4680): Flaky failures.
On 2016/02/02 11:26:10, Michael Achenbach wrote:
> Not sure if they are really flaky. On linux64 debug they seem to expect PASS
> deterministically:
>
https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20debug/buil...

Hmm weird. On my local machine these would fail in debug builds, and they fail
in the release bot AFAIKT. I'll take a look later and clean this up.

Powered by Google App Engine
This is Rietveld 408576698