Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1667323002:
[Interpreter] Group Ignition mjsunit test failures by error. (Closed)
|
Created:
4 years, 10 months ago by rmcilroy Modified:
4 years, 10 months ago Reviewers:
Michael Achenbach CC:
v8-reviews_googlegroups.com, oth, rmcilroy Base URL:
https://chromium.googlesource.com/v8/v8.git@myt_const Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[Interpreter] Group Ignition mjsunit test failures by error.
Also replace SKIPS by FAIL to ensure tests are reenabled once they work.
BUG=v8:4680
LOG=N
CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_arm64_dbg,v8_linux_arm_dbg
Committed: https://crrev.com/fe581185974079524cd2d59274830e4206340d9a
Cr-Commit-Position: refs/heads/master@{#33821}
Patch Set 1 #Patch Set 2 : Add a few more #Patch Set 3 : One more #Patch Set 4 : rebase #Patch Set 5 : One more on Arm64 #Patch Set 6 : Rebase #Patch Set 7 : One more on Arm64 #Messages
Total messages: 33 (17 generated)
The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1667323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1667323002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/build...)
The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1667323002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1667323002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1667323002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1667323002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/...) v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/...) v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/1...) v8_linux_arm_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/13371) v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...) v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...) v8_linux_mipsel_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...) v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/build...) v8_linux_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/1006) v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/10611)
Description was changed from ========== [Interpreter] Group Ignition mjsunit test failures by error. Also replace SKIPS by FAIL to ensure tests are reenabled once they work. BUG=v8:4680 LOG=N ========== to ========== [Interpreter] Group Ignition mjsunit test failures by error. Also replace SKIPS by FAIL to ensure tests are reenabled once they work. BUG=v8:4680 LOG=N CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_arm64_dbg,v8_linux_arm_dbg ==========
The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1667323002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1667323002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux_arm64_dbg on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_dbg/builds/255)
The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1667323002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1667323002/80001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1667323002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1667323002/100001
rmcilroy@chromium.org changed reviewers: + machenbach@chromium.org
Michael, could you take a look please?
lgtm (rubber-stamp). I didn't look into the details... as long as the bots stay green and fast, I'm ok with this.
The CQ bit was checked by rmcilroy@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from machenbach@chromium.org Link to the patchset: https://codereview.chromium.org/1667323002/#ps120001 (title: "One more on Arm64")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1667323002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1667323002/120001
Message was sent while issue was closed.
Description was changed from ========== [Interpreter] Group Ignition mjsunit test failures by error. Also replace SKIPS by FAIL to ensure tests are reenabled once they work. BUG=v8:4680 LOG=N CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_arm64_dbg,v8_linux_arm_dbg ========== to ========== [Interpreter] Group Ignition mjsunit test failures by error. Also replace SKIPS by FAIL to ensure tests are reenabled once they work. BUG=v8:4680 LOG=N CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_arm64_dbg,v8_linux_arm_dbg ==========
Message was sent while issue was closed.
Committed patchset #7 (id:120001)
Message was sent while issue was closed.
Description was changed from ========== [Interpreter] Group Ignition mjsunit test failures by error. Also replace SKIPS by FAIL to ensure tests are reenabled once they work. BUG=v8:4680 LOG=N CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_arm64_dbg,v8_linux_arm_dbg ========== to ========== [Interpreter] Group Ignition mjsunit test failures by error. Also replace SKIPS by FAIL to ensure tests are reenabled once they work. BUG=v8:4680 LOG=N CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_arm64_dbg,v8_linux_arm_dbg Committed: https://crrev.com/fe581185974079524cd2d59274830e4206340d9a Cr-Commit-Position: refs/heads/master@{#33821} ==========
Message was sent while issue was closed.
Patchset 7 (id:??) landed as https://crrev.com/fe581185974079524cd2d59274830e4206340d9a Cr-Commit-Position: refs/heads/master@{#33821} |
