Add counters to trace baseline code size.

Add counters to trace baseline code size.

BUG=v8:4280
LOG=N

Committed: https://crrev.com/72d768d1f93e8f270f134c409e267d6b80416666
Cr-Commit-Position: refs/heads/master@{#33688}

[rmcilroy, 2016-01-28 12:11:49]

rmcilroy@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[rmcilroy, 2016-01-28 12:11:50]

Michi: Please take a look. This is to allow us to trace code size for ignition
v.s. fullcodegen on the bots.

[rmcilroy, 2016-02-01 15:16:52]

Ping?

[Michael Starzinger, 2016-02-01 17:47:19]

LGTM with nits to address.

Off-topic: I am not going to rant about how compiler.cc is broken beyond repair,
let's just say that there is "room for improvement" in that file. :D

https://codereview.chromium.org/1649743002/diff/1/src/compiler.cc
File src/compiler.cc (right):

https://codereview.chromium.org/1649743002/diff/1/src/compiler.cc#newcode763
src/compiler.cc:763: size +=
FixedArray::SizeFor(bytecode_array->constant_pool()->length());
nit: Please use HeapObject::Size here.

https://codereview.chromium.org/1649743002/diff/1/src/compiler.cc#newcode764
src/compiler.cc:764: size +=
FixedArray::SizeFor(bytecode_array->handler_table()->length());
Likewise.

https://codereview.chromium.org/1649743002/diff/1/src/compiler.cc#newcode766
src/compiler.cc:766:
FixedArray::SizeFor(bytecode_array->source_position_table()->length());
Likwise.

https://codereview.chromium.org/1649743002/diff/1/src/compiler.cc#newcode771
src/compiler.cc:771: size +=
FixedArray::SizeFor(code->deoptimization_data()->length());
Likewise.

https://codereview.chromium.org/1649743002/diff/1/src/compiler.cc#newcode772
src/compiler.cc:772: size +=
FixedArray::SizeFor(code->handler_table()->length());
Likewise.

[rmcilroy, 2016-02-02 16:21:39]

https://codereview.chromium.org/1649743002/diff/1/src/compiler.cc
File src/compiler.cc (right):

https://codereview.chromium.org/1649743002/diff/1/src/compiler.cc#newcode763
src/compiler.cc:763: size +=
FixedArray::SizeFor(bytecode_array->constant_pool()->length());
On 2016/02/01 17:47:19, Michael Starzinger wrote:
> nit: Please use HeapObject::Size here.

Done.

https://codereview.chromium.org/1649743002/diff/1/src/compiler.cc#newcode764
src/compiler.cc:764: size +=
FixedArray::SizeFor(bytecode_array->handler_table()->length());
On 2016/02/01 17:47:19, Michael Starzinger wrote:
> Likewise.

Done.

https://codereview.chromium.org/1649743002/diff/1/src/compiler.cc#newcode766
src/compiler.cc:766:
FixedArray::SizeFor(bytecode_array->source_position_table()->length());
On 2016/02/01 17:47:19, Michael Starzinger wrote:
> Likwise.

Done.

https://codereview.chromium.org/1649743002/diff/1/src/compiler.cc#newcode771
src/compiler.cc:771: size +=
FixedArray::SizeFor(code->deoptimization_data()->length());
On 2016/02/01 17:47:19, Michael Starzinger wrote:
> Likewise.

Done.

https://codereview.chromium.org/1649743002/diff/1/src/compiler.cc#newcode772
src/compiler.cc:772: size +=
FixedArray::SizeFor(code->handler_table()->length());
On 2016/02/01 17:47:19, Michael Starzinger wrote:
> Likewise.

Done.

[rmcilroy, 2016-02-02 16:22:07]

The CQ bit was checked by rmcilroy@chromium.org

[rmcilroy, 2016-02-02 16:22:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1649743002/#ps20001
(title: "Review Comments")

[commit-bot: I haz the power, 2016-02-02 16:22:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1649743002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1649743002/20001

[commit-bot: I haz the power, 2016-02-02 16:48:10]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-02 16:51:55]

Description was changed from

==========
Add counters to trace baseline code size.

BUG=v8:4280
LOG=N
==========

to

==========
Add counters to trace baseline code size.

BUG=v8:4280
LOG=N

Committed: https://crrev.com/72d768d1f93e8f270f134c409e267d6b80416666
Cr-Commit-Position: refs/heads/master@{#33688}
==========

[commit-bot: I haz the power, 2016-02-02 16:51:56]

Patchset 2 (id:??) landed as
https://crrev.com/72d768d1f93e8f270f134c409e267d6b80416666
Cr-Commit-Position: refs/heads/master@{#33688}