Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 1694263002: [Turbofan] Save and restore lr in OutOfLineRecordWrite when frame is elided. (Closed)

Created:
4 years, 10 months ago by rmcilroy
Modified:
4 years, 10 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com, oth
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Turbofan] Save and restore lr in OutOfLineRecordWrite when frame is elided. Fixes a bug in Ignition on Arm64 where lr gets trashed in StaContextSlot which causes the stack walker to get confused and crash. BUG=v8:4680 LOG=N Committed: https://crrev.com/84a225d1e4e07c4d0b841ebc1cfb2ccf6c0a9c49 Cr-Commit-Position: refs/heads/master@{#34016}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -88 lines) Patch
M src/compiler/arm/code-generator-arm.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M src/compiler/mips/code-generator-mips.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M src/compiler/ppc/code-generator-ppc.cc View 1 chunk +10 lines, -2 lines 0 comments Download
M test/cctest/cctest.status View 1 chunk +0 lines, -17 lines 0 comments Download
M test/mjsunit/mjsunit.status View 2 chunks +6 lines, -61 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1694263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1694263002/1
4 years, 10 months ago (2016-02-15 15:03:12 UTC) #2
rmcilroy
Benedkit, PTAL, thanks.
4 years, 10 months ago (2016-02-15 15:03:28 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-15 15:24:41 UTC) #6
Benedikt Meurer
LGTM. Thanks for addressing this.
4 years, 10 months ago (2016-02-16 05:02:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1694263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1694263002/1
4 years, 10 months ago (2016-02-16 07:47:39 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-16 07:48:51 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 07:49:21 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/84a225d1e4e07c4d0b841ebc1cfb2ccf6c0a9c49
Cr-Commit-Position: refs/heads/master@{#34016}

Powered by Google App Engine
This is Rietveld 408576698