[Interpreter] Make InterpreterAssembler a subclass of CodeStubAssembler.

[Interpreter] Make InterpreterAssembler a subclass of CodeStubAssembler.

Moves InterpreterAssembler out of the compiler directory and into the
interpreter directory. Makes InterpreterAssembler as subclass of
CodeStubAssembler.

As part of this change, the special bytecode dispatch linkage type
is removed and instead we use a InterfaceDispatchDescriptor and
a normal CodeStub linkage type.

Removes a bunch of duplicated logic in InterpreterAssembler and
instead uses the CodeStubAssembler logic. Refactors Interpreter
with these changes.

Modifies CodeStubAssembler to add the extra operations required
by the Interpreter (extra call types, raw memory access and some extra
binary ops). Also adds the ability for subclasses to add extra
prologue and epilogue operations around calls, which is required
for the Interpreter.

BUG=v8:4280
LOG=N

Committed: https://crrev.com/d1c28849c77892ec74e58891aba44d5bfda8c0ba
Cr-Commit-Position: refs/heads/master@{#33873}

[rmcilroy, 2016-02-09 17:38:54]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-09 17:38:56]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1673333004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1673333004/1

[commit-bot: I haz the power, 2016-02-09 17:39:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-09 17:39:55]

Dry run: Try jobs failed on following builders:
  v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/...)
  v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/...)
  v8_linux_arm_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/13504)
  v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_mipsel_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/build...)
  v8_linux_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/1133)

[rmcilroy, 2016-02-09 17:40:08]

Description was changed from

==========
[Interpreter] Make InterpreterAssembler a subclass of CodeStubAssembler.

Moves InterpreterAssembler out of the compiler directory and into the
interpreter directory. Makes InterpreterAssembler as subclass of
CodeStubAssembler.

As part of this change, the special bytecode dispatch linkage type
is removed and instead we use a InterfaceDispatchDescriptor and
a normal CodeStub linkage type.

Removes a bunch of duplicated logic in InterpreterAssembler and
instead uses the CodeStubAssembler logic. Refactors Interpreter
with these changes.

Modifies CodeStubAssembler to add the extra operations required
by the Interpreter (mostly extra call types and some extra
binary ops). Also adds the ability for subclasses to add extra
prologue and epilogue operations around calls, which is required
for the Interpreter.

BUG=v8:4280
LOG=N
==========

to

==========
[Interpreter] Make InterpreterAssembler a subclass of CodeStubAssembler.

Moves InterpreterAssembler out of the compiler directory and into the
interpreter directory. Makes InterpreterAssembler as subclass of
CodeStubAssembler.

As part of this change, the special bytecode dispatch linkage type
is removed and instead we use a InterfaceDispatchDescriptor and
a normal CodeStub linkage type.

Removes a bunch of duplicated logic in InterpreterAssembler and
instead uses the CodeStubAssembler logic. Refactors Interpreter
with these changes.

Modifies CodeStubAssembler to add the extra operations required
by the Interpreter (extra call types, raw memory access and some extra
binary ops). Also adds the ability for subclasses to add extra
prologue and epilogue operations around calls, which is required
for the Interpreter.

BUG=v8:4280
LOG=N
==========

[rmcilroy, 2016-02-09 17:49:53]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-09 17:49:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1673333004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1673333004/20001

[commit-bot: I haz the power, 2016-02-09 17:52:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-09 17:52:13]

Dry run: Try jobs failed on following builders:
  v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/build...)

[rmcilroy, 2016-02-09 19:04:29]

Patchset #1 (id:1) has been deleted

[rmcilroy, 2016-02-09 19:04:35]

Patchset #2 (id:40001) has been deleted

[rmcilroy, 2016-02-09 19:05:20]

Patchset #1 (id:20001) has been deleted

[rmcilroy, 2016-02-09 19:05:25]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-09 19:05:33]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1673333004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1673333004/60001

[commit-bot: I haz the power, 2016-02-09 19:10:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-09 19:10:53]

Dry run: Try jobs failed on following builders:
  v8_mac_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/15203)
  v8_win_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/2561)

[rmcilroy, 2016-02-09 19:20:16]

Patchset #1 (id:60001) has been deleted

[rmcilroy, 2016-02-09 19:20:21]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-09 19:20:22]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1673333004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1673333004/80001

[commit-bot: I haz the power, 2016-02-09 19:40:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-09 19:40:53]

Dry run: Try jobs failed on following builders:
  v8_linux_dbg_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/1142)
  v8_linux_dbg_ng_triggered on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng_triggered/b...)

[rmcilroy, 2016-02-09 21:37:26]

rmcilroy@chromium.org changed reviewers:
+ epertoso@chromium.org, mstarzinger@chromium.org, oth@chromium.org

[rmcilroy, 2016-02-09 21:37:27]

Enrico, please take a look at code-assembler changes.
Orion, please take a look at the interpreter changes.
Michi, please take a look at the changes in compiler/ and interface-descriptors.

Thanks

[rmcilroy, 2016-02-10 10:14:12]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-10 10:14:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1673333004/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1673333004/100001

[commit-bot: I haz the power, 2016-02-10 10:46:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-10 10:46:51]

Dry run: This issue passed the CQ dry run.

[epertoso, 2016-02-10 11:05:37]

lgtm

https://codereview.chromium.org/1673333004/diff/80001/src/compiler/code-stub-...
File src/compiler/code-stub-assembler.h (right):

https://codereview.chromium.org/1673333004/diff/80001/src/compiler/code-stub-...
src/compiler/code-stub-assembler.h:69: V(UintPtrLessThanOrEqual)
I think you just need one of these two. It doesn't seem you're using
UintPtrLessThanOrEqual, but it would just be a matter of swapping the operands.

[oth, 2016-02-10 11:57:53]

lgtm, quite a change and for the better.

https://codereview.chromium.org/1673333004/diff/100001/src/compiler/code-stub...
File src/compiler/code-stub-assembler.h (right):

https://codereview.chromium.org/1673333004/diff/100001/src/compiler/code-stub...
src/compiler/code-stub-assembler.h:76: size_t result_size = 1);
Can you add a comment / TODO explaining result_size?

https://codereview.chromium.org/1673333004/diff/100001/src/interpreter/interp...
File src/interpreter/interpreter-assembler.h (right):

https://codereview.chromium.org/1673333004/diff/100001/src/interpreter/interp...
src/interpreter/interpreter-assembler.h:103: compiler::Node*
CallConstruct(compiler::Node* context,
The method definition differs from this declaration.
constructor, context, new_target, first_arg, arg_count.

[Michael Starzinger, 2016-02-10 12:51:37]

LGTM. Nice, I like! Just nits.

https://codereview.chromium.org/1673333004/diff/100001/src/compiler/linkage.h
File src/compiler/linkage.h (left):

https://codereview.chromium.org/1673333004/diff/100001/src/compiler/linkage.h...
src/compiler/linkage.h:342: static CallDescriptor*
GetInterpreterDispatchDescriptor(Zone* zone);
Woot! Love it!

https://codereview.chromium.org/1673333004/diff/100001/src/interpreter/DEPS
File src/interpreter/DEPS (left):

https://codereview.chromium.org/1673333004/diff/100001/src/interpreter/DEPS#o...
src/interpreter/DEPS:2: "+src/compiler/interpreter-assembler.h",
I think we can also adapt the top-level WATCHLISTS file to no longer contain the
"src/compiler/interpreter*" pattern. WDYT?

https://codereview.chromium.org/1673333004/diff/100001/src/interpreter/interp...
File src/interpreter/interpreter-assembler.h (right):

https://codereview.chromium.org/1673333004/diff/100001/src/interpreter/interp...
src/interpreter/interpreter-assembler.h:24: class Node;
nit: This forward declaration should be provided by code-stub-assembler.h
already. Can we drop it?

https://codereview.chromium.org/1673333004/diff/100001/src/interpreter/interp...
src/interpreter/interpreter-assembler.h:201: #endif  //
V8_COMPILER_INTERPRETER_ASSEMBLER_H_
nit: V8_INTERPRETER_INTERPRETER_ASSEMBLER_H_

https://codereview.chromium.org/1673333004/diff/100001/test/unittests/interpr...
File test/unittests/interpreter/interpreter-assembler-unittest.h (right):

https://codereview.chromium.org/1673333004/diff/100001/test/unittests/interpr...
test/unittests/interpreter/interpreter-assembler-unittest.h:57: #endif  //
V8_UNITTESTS_COMPILER_INTERPRETER_ASSEMBLER_UNITTEST_H_
nit: V8_UNITTESTS_INTERPRETER_INTERPRETER_ASSEMBLER_UNITTEST_H_

[rmcilroy, 2016-02-10 16:13:40]

https://codereview.chromium.org/1673333004/diff/80001/src/compiler/code-stub-...
File src/compiler/code-stub-assembler.h (right):

https://codereview.chromium.org/1673333004/diff/80001/src/compiler/code-stub-...
src/compiler/code-stub-assembler.h:69: V(UintPtrLessThanOrEqual)
On 2016/02/10 11:05:37, epertoso wrote:
> I think you just need one of these two. It doesn't seem you're using
> UintPtrLessThanOrEqual, but it would just be a matter of swapping the
operands.

Sure, I was just trying to keep things consistent (e.g., nobody uses Word64Xor
above either yet, but it was presumably added for consistency). Removed for now
until we need it.

https://codereview.chromium.org/1673333004/diff/100001/src/compiler/code-stub...
File src/compiler/code-stub-assembler.h (right):

https://codereview.chromium.org/1673333004/diff/100001/src/compiler/code-stub...
src/compiler/code-stub-assembler.h:76: size_t result_size = 1);
On 2016/02/10 11:57:53, oth wrote:
> Can you add a comment / TODO explaining result_size?

Done.

https://codereview.chromium.org/1673333004/diff/100001/src/compiler/linkage.h
File src/compiler/linkage.h (left):

https://codereview.chromium.org/1673333004/diff/100001/src/compiler/linkage.h...
src/compiler/linkage.h:342: static CallDescriptor*
GetInterpreterDispatchDescriptor(Zone* zone);
On 2016/02/10 12:51:36, Michael Starzinger wrote:
> Woot! Love it!

Acknowledged :).

https://codereview.chromium.org/1673333004/diff/100001/src/interpreter/DEPS
File src/interpreter/DEPS (left):

https://codereview.chromium.org/1673333004/diff/100001/src/interpreter/DEPS#o...
src/interpreter/DEPS:2: "+src/compiler/interpreter-assembler.h",
On 2016/02/10 12:51:36, Michael Starzinger wrote:
> I think we can also adapt the top-level WATCHLISTS file to no longer contain
the
> "src/compiler/interpreter*" pattern. WDYT?

Done.

https://codereview.chromium.org/1673333004/diff/100001/src/interpreter/interp...
File src/interpreter/interpreter-assembler.h (right):

https://codereview.chromium.org/1673333004/diff/100001/src/interpreter/interp...
src/interpreter/interpreter-assembler.h:24: class Node;
On 2016/02/10 12:51:36, Michael Starzinger wrote:
> nit: This forward declaration should be provided by code-stub-assembler.h
> already. Can we drop it?

Done, also removed other forward declarations as they aren't needed either.

https://codereview.chromium.org/1673333004/diff/100001/src/interpreter/interp...
src/interpreter/interpreter-assembler.h:103: compiler::Node*
CallConstruct(compiler::Node* context,
On 2016/02/10 11:57:53, oth wrote:
> The method definition differs from this declaration.
> constructor, context, new_target, first_arg, arg_count.

Good catch, thanks!

https://codereview.chromium.org/1673333004/diff/100001/src/interpreter/interp...
src/interpreter/interpreter-assembler.h:201: #endif  //
V8_COMPILER_INTERPRETER_ASSEMBLER_H_
On 2016/02/10 12:51:36, Michael Starzinger wrote:
> nit: V8_INTERPRETER_INTERPRETER_ASSEMBLER_H_

Done.

https://codereview.chromium.org/1673333004/diff/100001/test/unittests/interpr...
File test/unittests/interpreter/interpreter-assembler-unittest.h (right):

https://codereview.chromium.org/1673333004/diff/100001/test/unittests/interpr...
test/unittests/interpreter/interpreter-assembler-unittest.h:57: #endif  //
V8_UNITTESTS_COMPILER_INTERPRETER_ASSEMBLER_UNITTEST_H_
On 2016/02/10 12:51:36, Michael Starzinger wrote:
> nit: V8_UNITTESTS_INTERPRETER_INTERPRETER_ASSEMBLER_UNITTEST_H_

Done.

[rmcilroy, 2016-02-10 16:14:44]

The CQ bit was checked by rmcilroy@chromium.org

[rmcilroy, 2016-02-10 16:14:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
epertoso@chromium.org, oth@chromium.org, mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1673333004/#ps120001
(title: "Address review comments.")

[commit-bot: I haz the power, 2016-02-10 16:14:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1673333004/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1673333004/120001

[commit-bot: I haz the power, 2016-02-10 16:38:55]

Description was changed from

==========
[Interpreter] Make InterpreterAssembler a subclass of CodeStubAssembler.

Moves InterpreterAssembler out of the compiler directory and into the
interpreter directory. Makes InterpreterAssembler as subclass of
CodeStubAssembler.

As part of this change, the special bytecode dispatch linkage type
is removed and instead we use a InterfaceDispatchDescriptor and
a normal CodeStub linkage type.

Removes a bunch of duplicated logic in InterpreterAssembler and
instead uses the CodeStubAssembler logic. Refactors Interpreter
with these changes.

Modifies CodeStubAssembler to add the extra operations required
by the Interpreter (extra call types, raw memory access and some extra
binary ops). Also adds the ability for subclasses to add extra
prologue and epilogue operations around calls, which is required
for the Interpreter.

BUG=v8:4280
LOG=N
==========

to

==========
[Interpreter] Make InterpreterAssembler a subclass of CodeStubAssembler.

Moves InterpreterAssembler out of the compiler directory and into the
interpreter directory. Makes InterpreterAssembler as subclass of
CodeStubAssembler.

As part of this change, the special bytecode dispatch linkage type
is removed and instead we use a InterfaceDispatchDescriptor and
a normal CodeStub linkage type.

Removes a bunch of duplicated logic in InterpreterAssembler and
instead uses the CodeStubAssembler logic. Refactors Interpreter
with these changes.

Modifies CodeStubAssembler to add the extra operations required
by the Interpreter (extra call types, raw memory access and some extra
binary ops). Also adds the ability for subclasses to add extra
prologue and epilogue operations around calls, which is required
for the Interpreter.

BUG=v8:4280
LOG=N
==========

[commit-bot: I haz the power, 2016-02-10 16:38:56]

Committed patchset #3 (id:120001)

[commit-bot: I haz the power, 2016-02-10 16:39:39]

Description was changed from

==========
[Interpreter] Make InterpreterAssembler a subclass of CodeStubAssembler.

Moves InterpreterAssembler out of the compiler directory and into the
interpreter directory. Makes InterpreterAssembler as subclass of
CodeStubAssembler.

As part of this change, the special bytecode dispatch linkage type
is removed and instead we use a InterfaceDispatchDescriptor and
a normal CodeStub linkage type.

Removes a bunch of duplicated logic in InterpreterAssembler and
instead uses the CodeStubAssembler logic. Refactors Interpreter
with these changes.

Modifies CodeStubAssembler to add the extra operations required
by the Interpreter (extra call types, raw memory access and some extra
binary ops). Also adds the ability for subclasses to add extra
prologue and epilogue operations around calls, which is required
for the Interpreter.

BUG=v8:4280
LOG=N
==========

to

==========
[Interpreter] Make InterpreterAssembler a subclass of CodeStubAssembler.

Moves InterpreterAssembler out of the compiler directory and into the
interpreter directory. Makes InterpreterAssembler as subclass of
CodeStubAssembler.

As part of this change, the special bytecode dispatch linkage type
is removed and instead we use a InterfaceDispatchDescriptor and
a normal CodeStub linkage type.

Removes a bunch of duplicated logic in InterpreterAssembler and
instead uses the CodeStubAssembler logic. Refactors Interpreter
with these changes.

Modifies CodeStubAssembler to add the extra operations required
by the Interpreter (extra call types, raw memory access and some extra
binary ops). Also adds the ability for subclasses to add extra
prologue and epilogue operations around calls, which is required
for the Interpreter.

BUG=v8:4280
LOG=N

Committed: https://crrev.com/d1c28849c77892ec74e58891aba44d5bfda8c0ba
Cr-Commit-Position: refs/heads/master@{#33873}
==========

[commit-bot: I haz the power, 2016-02-10 16:39:41]

Patchset 3 (id:??) landed as
https://crrev.com/d1c28849c77892ec74e58891aba44d5bfda8c0ba
Cr-Commit-Position: refs/heads/master@{#33873}