Typed CSS OM: implement TransformComponent::asMatrix

Typed CSS OM: implement TransformComponent::asMatrix

All methods used for generating the underlying matrix in asMatrix
are in MatrixTransformComponent.cpp

Constructs each MatrixTransformComponent for use in
asMatrix methods manually, rather than using inbuilt
methods to avoid unnecessary matrix multiplication.
(With the exception of rotate and rotate3d, as they require
far more complex calculations.)

Note: asMatrix for a MatrixTransformComponent returns a clone.

BUG=545318
Committed: https://crrev.com/2a40cf093c3a596c0658e12cd24a32086817f057
Cr-Commit-Position: refs/heads/master@{#374770}

[tridgell, 2016-02-04 04:42:51]

tridgell@google.com changed reviewers:
+ meade@chromium.org

[meade_UTC10, 2016-02-04 06:50:11]

meade@chromium.org changed reviewers:
+ ericwilligers@chromium.org

[meade_UTC10, 2016-02-04 06:50:12]

lgtm

Looks pretty good to me, adding Eric to for more experienced eye

https://codereview.chromium.org/1648853002/diff/80001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/typedcssom/matrixTransformComponent.html
(right):

https://codereview.chromium.org/1648853002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/typedcssom/matrixTransformComponent.html:78: },
"Test that asMatrix has all the same properties as the original
MatrixTransformComponent.");
Don't forget to change this from MatrixTransformComponent -> Matrix to be
consistent with your other CL

https://codereview.chromium.org/1648853002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/cssom/MatrixTransformComponent.h
(right):

https://codereview.chromium.org/1648853002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/cssom/MatrixTransformComponent.h:75:
MatrixTransformComponent* clone() const;
What do you need clone for again?

[Eric Willigers, 2016-02-05 01:16:34]

We can use smart pointers when allocating TransformationMatrix.

https://codereview.chromium.org/1648853002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/cssom/MatrixTransformComponent.cpp
(right):

https://codereview.chromium.org/1648853002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/cssom/MatrixTransformComponent.cpp:44:
TransformationMatrix* matrix = new TransformationMatrix();
Store in OwnPtr

https://codereview.chromium.org/1648853002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/cssom/MatrixTransformComponent.cpp:47: return
new MatrixTransformComponent(matrix, PerspectiveType);
matrix.release()

https://codereview.chromium.org/1648853002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/cssom/MatrixTransformComponent.h
(right):

https://codereview.chromium.org/1648853002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/cssom/MatrixTransformComponent.h:93:
MatrixTransformComponent(TransformationMatrix* const matrix,
TransformComponentType fromType)
PassOwnPtr<TransformationMatrix>

[tridgell, 2016-02-08 01:00:14]

https://codereview.chromium.org/1648853002/diff/80001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/typedcssom/matrixTransformComponent.html
(right):

https://codereview.chromium.org/1648853002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/typedcssom/matrixTransformComponent.html:78: },
"Test that asMatrix has all the same properties as the original
MatrixTransformComponent.");
On 2016/02/04 06:50:11, Eddy wrote:
> Don't forget to change this from MatrixTransformComponent -> Matrix to be
> consistent with your other CL

Done.

https://codereview.chromium.org/1648853002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/cssom/MatrixTransformComponent.cpp
(right):

https://codereview.chromium.org/1648853002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/cssom/MatrixTransformComponent.cpp:44:
TransformationMatrix* matrix = new TransformationMatrix();
On 2016/02/05 at 01:16:34, Eric Willigers wrote:
> Store in OwnPtr

Done.  This will hopefully change to TransformationMatrix::create()
if https://codereview.chromium.org/1673093003 goes through.

https://codereview.chromium.org/1648853002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/cssom/MatrixTransformComponent.cpp:47: return
new MatrixTransformComponent(matrix, PerspectiveType);
On 2016/02/05 at 01:16:34, Eric Willigers wrote:
> matrix.release()

Done.

https://codereview.chromium.org/1648853002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/cssom/MatrixTransformComponent.h
(right):

https://codereview.chromium.org/1648853002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/cssom/MatrixTransformComponent.h:75:
MatrixTransformComponent* clone() const;
On 2016/02/04 06:50:11, Eddy wrote:
> What do you need clone for again?

Done. Removed.
Was using clone for the asMatrix.
Changed asMatrix to use a const_cast instead and remove
MatrixTransformComponent::clone()

https://codereview.chromium.org/1648853002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/cssom/MatrixTransformComponent.h:93:
MatrixTransformComponent(TransformationMatrix* const matrix,
TransformComponentType fromType)
On 2016/02/05 at 01:16:34, Eric Willigers wrote:
> PassOwnPtr<TransformationMatrix>

Done. Using PassOwnPtr<const TransformationMatrix>

[Eric Willigers, 2016-02-08 03:13:15]

lgtm

[meade_UTC10, 2016-02-08 03:44:45]

Description was changed from

==========
Typed CSS OM: implement TransformComponent::asMatrix

All methods used for generating the underlying matrix in asMatrix
are in MatrixTransformComponent.cpp

Constructs each MatrixTransformComponent for use in
asMatrix methods manually, rather than using inbuilt
methods to avoid unnecessary matrix multiplication.
(With the exception of rotate and rotate3d, as they require
far more complex calculations.)

Note: asMatrix for a MatrixTransformComponent returns a clone.

BUG=545318
==========

to

==========
Typed CSS OM: implement TransformComponent::asMatrix

All methods used for generating the underlying matrix in asMatrix
are in MatrixTransformComponent.cpp

Constructs each MatrixTransformComponent for use in
asMatrix methods manually, rather than using inbuilt
methods to avoid unnecessary matrix multiplication.
(With the exception of rotate and rotate3d, as they require
far more complex calculations.)

Note: asMatrix for a MatrixTransformComponent returns a clone.

BUG=545318
==========

[meade_UTC10, 2016-02-08 03:44:45]

meade@chromium.org changed reviewers:
+ timloh@chromium.org

[Timothy Loh, 2016-02-10 06:22:13]

ok lgtm

[tridgell, 2016-02-10 23:02:01]

The CQ bit was checked by tridgell@google.com

[tridgell, 2016-02-10 23:02:01]

The patchset sent to the CQ was uploaded after l-g-t-m from meade@chromium.org,
ericwilligers@chromium.org
Link to the patchset: https://codereview.chromium.org/1648853002/#ps120001
(title: "Use TransformationMatrix::create")

[commit-bot: I haz the power, 2016-02-10 23:04:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1648853002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1648853002/120001

[commit-bot: I haz the power, 2016-02-10 23:14:51]

Description was changed from

==========
Typed CSS OM: implement TransformComponent::asMatrix

All methods used for generating the underlying matrix in asMatrix
are in MatrixTransformComponent.cpp

Constructs each MatrixTransformComponent for use in
asMatrix methods manually, rather than using inbuilt
methods to avoid unnecessary matrix multiplication.
(With the exception of rotate and rotate3d, as they require
far more complex calculations.)

Note: asMatrix for a MatrixTransformComponent returns a clone.

BUG=545318
==========

to

==========
Typed CSS OM: implement TransformComponent::asMatrix

All methods used for generating the underlying matrix in asMatrix
are in MatrixTransformComponent.cpp

Constructs each MatrixTransformComponent for use in
asMatrix methods manually, rather than using inbuilt
methods to avoid unnecessary matrix multiplication.
(With the exception of rotate and rotate3d, as they require
far more complex calculations.)

Note: asMatrix for a MatrixTransformComponent returns a clone.

BUG=545318
==========

[commit-bot: I haz the power, 2016-02-10 23:14:52]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-02-16 22:32:14]

Description was changed from

==========
Typed CSS OM: implement TransformComponent::asMatrix

All methods used for generating the underlying matrix in asMatrix
are in MatrixTransformComponent.cpp

Constructs each MatrixTransformComponent for use in
asMatrix methods manually, rather than using inbuilt
methods to avoid unnecessary matrix multiplication.
(With the exception of rotate and rotate3d, as they require
far more complex calculations.)

Note: asMatrix for a MatrixTransformComponent returns a clone.

BUG=545318
==========

to

==========
Typed CSS OM: implement TransformComponent::asMatrix

All methods used for generating the underlying matrix in asMatrix
are in MatrixTransformComponent.cpp

Constructs each MatrixTransformComponent for use in
asMatrix methods manually, rather than using inbuilt
methods to avoid unnecessary matrix multiplication.
(With the exception of rotate and rotate3d, as they require
far more complex calculations.)

Note: asMatrix for a MatrixTransformComponent returns a clone.

BUG=545318

Committed: https://crrev.com/2a40cf093c3a596c0658e12cd24a32086817f057
Cr-Commit-Position: refs/heads/master@{#374770}
==========

[commit-bot: I haz the power, 2016-02-16 22:32:15]

Patchset 7 (id:??) landed as
https://crrev.com/2a40cf093c3a596c0658e12cd24a32086817f057
Cr-Commit-Position: refs/heads/master@{#374770}