blink::TransformationMatrix implement create methods

blink::TransformationMatrix implement create methods

TransformationMatrix is currently unsupported by Oilpan.
Muliple classes on Oilpan have an OwnPtr<TransformationMatrix> member.

To tidy up these classes and references, it is prefered to have
create methods on TransformationMatrix, rather than having
adoptPtr(new TransformationMatrix...)

That is,
adoptPtr(new TransformationMatrix) -> TransformationMatrix::create

BUG=

Committed: https://crrev.com/a0e5d2909f6d158a4538b017fa51587ada5b41b1
Cr-Commit-Position: refs/heads/master@{#374285}

[tridgell, 2016-02-07 23:24:18]

tridgell@google.com changed reviewers:
+ alancutter@chromium.org

[Eric Willigers, 2016-02-08 03:22:45]

Define

private:
  void* operator new(size_t count) { return ::operator new(count); }

Then the following succeed:
  TransformationMatrix first;
  OwnPtr<TransformationMatrix> second = TransformationMatrix::create();
and the following fails:
  TransformationMatrix* third = new TransformationMatrix();

[tridgell, 2016-02-08 03:35:25]

On 2016/02/08 at 03:22:45, ericwilligers wrote:
> Define
> 
> private:
>   void* operator new(size_t count) { return ::operator new(count); }
> 
> Then the following succeed:
>   TransformationMatrix first;
>   OwnPtr<TransformationMatrix> second = TransformationMatrix::create();
> and the following fails:
>   TransformationMatrix* third = new TransformationMatrix();

I unfortunately can't.
The new operator is already declared in the USING_FAST_MALLOC macro in public
scope.
(and the macro is used in TransformationMatrix)
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

[Eric Willigers, 2016-02-08 03:40:27]

ericwilligers@chromium.org changed reviewers:
+ ericwilligers@chromium.org

[Eric Willigers, 2016-02-08 03:40:27]

lgtm

[tridgell, 2016-02-08 04:18:07]

tridgell@google.com changed reviewers:
+ noel@chromium.org

[alancutter (OOO until 2018), 2016-02-08 04:29:53]

https://codereview.chromium.org/1673093003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/transforms/TransformationMatrix.h
(right):

https://codereview.chromium.org/1673093003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/transforms/TransformationMatrix.h:86: }
Are all these needed? Can we omit any that aren't being used?

[Noel Gordon, 2016-02-08 04:33:08]

LGTM with nits addressed.

[tridgell, 2016-02-08 05:30:54]

https://codereview.chromium.org/1673093003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/transforms/TransformationMatrix.h
(right):

https://codereview.chromium.org/1673093003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/transforms/TransformationMatrix.h:86: }
On 2016/02/08 at 04:29:52, alancutter wrote:
> Are all these needed? Can we omit any that aren't being used?

Done.  Removed.  The only unused one was create(const AffineTransform&).

[alancutter (OOO until 2018), 2016-02-09 00:02:12]

lgtm

[tridgell, 2016-02-09 00:20:56]

The CQ bit was checked by tridgell@google.com

[tridgell, 2016-02-09 00:20:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
ericwilligers@chromium.org, noel@chromium.org
Link to the patchset: https://codereview.chromium.org/1673093003/#ps40001
(title: "Remove TransfromationMatrix::create(const AffineTransform&)")

[commit-bot: I haz the power, 2016-02-09 00:24:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1673093003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1673093003/40001

[commit-bot: I haz the power, 2016-02-09 00:52:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-09 00:52:13]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[tridgell, 2016-02-09 01:20:56]

tridgell@google.com changed reviewers:
+ timloh@chromium.org

[alancutter (OOO until 2018), 2016-02-09 01:47:43]

On 2016/02/09 at 00:52:13, commit-bot wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

Looks like you still need core OWNERS approval (timloh).

[Timothy Loh, 2016-02-09 02:09:13]

On 2016/02/09 01:47:43, alancutter wrote:
> On 2016/02/09 at 00:52:13, commit-bot wrote:
> > Try jobs failed on following builders:
> >   chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
> 
> Looks like you still need core OWNERS approval (timloh).

lgtm

[tridgell, 2016-02-09 02:50:50]

The CQ bit was checked by tridgell@google.com

[commit-bot: I haz the power, 2016-02-09 02:55:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1673093003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1673093003/40001

[commit-bot: I haz the power, 2016-02-09 03:09:50]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-02-09 03:11:58]

Description was changed from

==========
blink::TransformationMatrix implement create methods

TransformationMatrix is currently unsupported by Oilpan.
Muliple classes on Oilpan have an OwnPtr<TransformationMatrix> member.

To tidy up these classes and references, it is prefered to have
create methods on TransformationMatrix, rather than having
adoptPtr(new TransformationMatrix...)

That is,
adoptPtr(new TransformationMatrix) -> TransformationMatrix::create

BUG=
==========

to

==========
blink::TransformationMatrix implement create methods

TransformationMatrix is currently unsupported by Oilpan.
Muliple classes on Oilpan have an OwnPtr<TransformationMatrix> member.

To tidy up these classes and references, it is prefered to have
create methods on TransformationMatrix, rather than having
adoptPtr(new TransformationMatrix...)

That is,
adoptPtr(new TransformationMatrix) -> TransformationMatrix::create

BUG=

Committed: https://crrev.com/a0e5d2909f6d158a4538b017fa51587ada5b41b1
Cr-Commit-Position: refs/heads/master@{#374285}
==========

[commit-bot: I haz the power, 2016-02-09 03:12:00]

Patchset 3 (id:??) landed as
https://crrev.com/a0e5d2909f6d158a4538b017fa51587ada5b41b1
Cr-Commit-Position: refs/heads/master@{#374285}