third_party/WebKit/Source/core/css/cssom/TransformComponent.h - Issue 1648853002: Typed CSS OM: implement TransformComponent::asMatrix

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/cssom/TransformComponent.h

Issue 1648853002: Typed CSS OM: implement TransformComponent::asMatrix (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@asMatrixTransformMethod

Patch Set: Use TransformationMatrix::create Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/cssom/SkewTransformComponent.h ('k') | third_party/WebKit/Source/core/css/cssom/TransformComponent.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/cssom/TransformComponent.h

diff --git a/third_party/WebKit/Source/core/css/cssom/TransformComponent.h b/third_party/WebKit/Source/core/css/cssom/TransformComponent.h

index 8cd9db6c21600dc43f24c868e62909d9490180f9..e5b169cd0f0892e32e0a5c712c31f7c9c264a0dc 100644

--- a/third_party/WebKit/Source/core/css/cssom/TransformComponent.h

+++ b/third_party/WebKit/Source/core/css/cssom/TransformComponent.h

@@ -11,6 +11,8 @@

namespace blink {

+class MatrixTransformComponent;

class CORE_EXPORT TransformComponent : public GarbageCollectedFinalized<TransformComponent>, public ScriptWrappable {

WTF_MAKE_NONCOPYABLE(TransformComponent);

DEFINE_WRAPPERTYPEINFO();

@@ -24,9 +26,10 @@ public:

virtual TransformComponentType type() const = 0;

- bool is2DComponent() const

+ bool is2DComponent() const { return is2DComponentType(type()); }

+ static bool is2DComponentType(TransformComponentType transformType)

{

- TransformComponentType transformType = type();

return transformType != Matrix3DType

&& transformType != PerspectiveType

&& transformType != Rotation3DType

@@ -41,6 +44,7 @@ public:

}

virtual PassRefPtrWillBeRawPtr<CSSFunctionValue> toCSSValue() const = 0;

+ virtual MatrixTransformComponent* asMatrix() const = 0;

DEFINE_INLINE_VIRTUAL_TRACE() { }