third_party/WebKit/Source/core/css/cssom/RotationTransformComponent.h - Issue 1648853002: Typed CSS OM: implement TransformComponent::asMatrix

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/cssom/RotationTransformComponent.h

Issue 1648853002: Typed CSS OM: implement TransformComponent::asMatrix (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@asMatrixTransformMethod

Patch Set: Use TransformationMatrix::create Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/cssom/PerspectiveTransformComponent.h ('k') | third_party/WebKit/Source/core/css/cssom/ScaleTransformComponent.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/cssom/RotationTransformComponent.h

diff --git a/third_party/WebKit/Source/core/css/cssom/RotationTransformComponent.h b/third_party/WebKit/Source/core/css/cssom/RotationTransformComponent.h

index 2b825ed98d5df356bd1cc0dc0c941727550cdde9..0448e14013e1c7c9a16181033eb29655ad1382af 100644

--- a/third_party/WebKit/Source/core/css/cssom/RotationTransformComponent.h

+++ b/third_party/WebKit/Source/core/css/cssom/RotationTransformComponent.h

@@ -5,6 +5,7 @@

#ifndef RotationTransformComponent_h

#define RotationTransformComponent_h

+#include "core/css/cssom/MatrixTransformComponent.h"

#include "core/css/cssom/TransformComponent.h"

namespace blink {

@@ -30,6 +31,12 @@ public:

TransformComponentType type() const override { return m_is2D ? RotationType : Rotation3DType; }

+ MatrixTransformComponent* asMatrix() const override

+ {

+ return m_is2D ? MatrixTransformComponent::rotate(m_angle)

+ : MatrixTransformComponent::rotate3d(m_angle, m_x, m_y, m_z);

+ }

PassRefPtrWillBeRawPtr<CSSFunctionValue> toCSSValue() const override;

private: