Add vmov between floating point registers to ARM assembler.

Add vmov between floating point registers to ARM assembler.

Adds generating binary versions of vmov for moves between floating
point registers, in the integrated ARM assembler.

Also adds simple lit test. Also simplifies the lit test for push/pop
(which had to be changed anyway since it included vmov instructions as
well).

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
R=eholk@chromium.org, jpp@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=9aedc2e90f2220f7811ef8690a8b0fd59a4d7784

[Karl, 2016-01-27 20:29:25]

Description was changed from

==========
Add vmov between floating point registers to ARM assembler.

Adds generating binary versions of vmov for moves between floating
point registers, in the integrated ARM assembler.

Also adds simple lit test. Also simplifies the lit test for push/pop
(which had to be changed anyway since it included vmov instructions as
well).

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
==========

to

==========
Add vmov between floating point registers to ARM assembler.

Adds generating binary versions of vmov for moves between floating
point registers, in the integrated ARM assembler.

Also adds simple lit test. Also simplifies the lit test for push/pop
(which had to be changed anyway since it included vmov instructions as
well).

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
==========

[Karl, 2016-01-27 20:29:25]

kschimpf@google.com changed reviewers:
+ eholk@chromium.org, jpp@chromium.org, sehr@chromium.org, stichnot@chromium.org

[Eric Holk, 2016-01-27 20:50:27]

lgtm

[John, 2016-01-27 21:12:20]

lgtm

[Karl, 2016-01-27 21:36:12]

Description was changed from

==========
Add vmov between floating point registers to ARM assembler.

Adds generating binary versions of vmov for moves between floating
point registers, in the integrated ARM assembler.

Also adds simple lit test. Also simplifies the lit test for push/pop
(which had to be changed anyway since it included vmov instructions as
well).

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
==========

to

==========
Add vmov between floating point registers to ARM assembler.

Adds generating binary versions of vmov for moves between floating
point registers, in the integrated ARM assembler.

Also adds simple lit test. Also simplifies the lit test for push/pop
(which had to be changed anyway since it included vmov instructions as
well).

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
R=eholk@chromium.org, jpp@chromium.org

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[Karl, 2016-01-27 21:36:13]

Committed patchset #2 (id:20001) manually as
9aedc2e90f2220f7811ef8690a8b0fd59a4d7784 (presubmit successful).

[Jim Stichnoth, 2016-01-27 22:10:50]

https://codereview.chromium.org/1645683003/diff/20001/src/DartARM32/assembler...
File src/DartARM32/assembler_arm.cc (right):

https://codereview.chromium.org/1645683003/diff/20001/src/DartARM32/assembler...
src/DartARM32/assembler_arm.cc:930: #endif
Remove this and the following "#if 0".  Woohoo!

https://codereview.chromium.org/1645683003/diff/20001/src/IceInstARM32.cpp
File src/IceInstARM32.cpp (right):

https://codereview.chromium.org/1645683003/diff/20001/src/IceInstARM32.cpp#ne...
src/IceInstARM32.cpp:1063: assert(llvm::isa<Variable>(Src) && Src->hasReg());
llvm::isa<Variable>(Src) is redundant with the llvm::cast<Variable> above and
can be removed.

https://codereview.chromium.org/1645683003/diff/20001/src/IceInstARM32.cpp#ne...
src/IceInstARM32.cpp:1163: if (llvm::isa<Variable>(Src0)) {
Are vmovss and vmovdd always going to have a Variable as their second argument? 
If so, I would change their declarations from Operand to Variable in that
parameter.

[Karl, 2016-01-27 22:58:09]

See CL https://codereview.chromium.org/1641753003 for changes.

https://codereview.chromium.org/1645683003/diff/20001/src/DartARM32/assembler...
File src/DartARM32/assembler_arm.cc (right):

https://codereview.chromium.org/1645683003/diff/20001/src/DartARM32/assembler...
src/DartARM32/assembler_arm.cc:930: #endif
On 2016/01/27 22:10:49, stichnot wrote:
> Remove this and the following "#if 0".  Woohoo!

Done.

https://codereview.chromium.org/1645683003/diff/20001/src/IceInstARM32.cpp
File src/IceInstARM32.cpp (right):

https://codereview.chromium.org/1645683003/diff/20001/src/IceInstARM32.cpp#ne...
src/IceInstARM32.cpp:1063: assert(llvm::isa<Variable>(Src) && Src->hasReg());
On 2016/01/27 22:10:49, stichnot wrote:
> llvm::isa<Variable>(Src) is redundant with the llvm::cast<Variable> above and
> can be removed.

Done.

https://codereview.chromium.org/1645683003/diff/20001/src/IceInstARM32.cpp#ne...
src/IceInstARM32.cpp:1163: if (llvm::isa<Variable>(Src0)) {
On 2016/01/27 22:10:49, stichnot wrote:
> Are vmovss and vmovdd always going to have a Variable as their second
argument? 
> If so, I would change their declarations from Operand to Variable in that
> parameter.

Done.